Upgrade actions to node 20 #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this upgrade's ONLY breaking change is dropping Node.js 16 in favor of Node.js 20: See https://github.com/actions/checkout/blob/v4/CHANGELOG.md#v400 Signed-off-by: Steven Kalt <[email protected]>
Note that the only breaking change in this update is dropping node.js 16 in favor of node.js 20: see https://github.com/actions/cache/blob/v4/RELEASES.md#400 Signed-off-by: Steven Kalt <[email protected]>
The only breaking change should be an upgrade to node.js 20: see actions/setup-node@v3...v4.0.2 Signed-off-by: Steven Kalt <[email protected]>
This is a trickier upgrade, since v4 of github's artifact-handling actions drop the ability to append to artifacts with the same name: see https://github.com/actions/upload-artifact/tree/552bf3722c16e81001aea7db72d8cedf64eb5f68?tab=readme-ov-file#v4---whats-new To work around the new naming restrictions, I invoke actions/download-artifact for each target and chuck the files into the expected directories. Signed-off-by: Steven Kalt <[email protected]>
SKalt
force-pushed
the
upgrade-actions-to-node-20
branch
from
90c0f6e to
000ab70
Compare
bglw
requested changes
Jul 10, 2024
There was a problem hiding this comment.
👋 Thanks for this!
One change, you can use the pattern and merge-multiple options for downloading multiple artifacts in one go: https://github.com/actions/download-artifact?tab=readme-ov-file#download-multiple-filtered-artifacts-to-the-same-directory
Saves us from having to enumerate the downloads 🙂
bglw
approved these changes
Jul 16, 2024
bglw
requested changes
Jul 16, 2024
SKalt
force-pushed
the
upgrade-actions-to-node-20
branch
from
8b53f3a to
8520485
Compare
bglw
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #651 as much as possible: there are no newer versions of
jetli/wasm-pack-action, andactions-rs/toolchainwas archived after v1.0.6.See the commit log for details about each actions' changelog.