ci: upgrade actions/{up,down}load-artifact to v4

This is a trickier upgrade, since v4 of github's artifact-handling actions drop the ability to append to artifacts with the same name: see https://github.com/actions/upload-artifact/tree/552bf3722c16e81001aea7db72d8cedf64eb5f68?tab=readme-ov-file#v4---whats-new To work around the new naming restrictions, I invoke actions/download-artifact for each target and chuck the files into the expected directories. Signed-off-by: Steven Kalt <[email protected]>
CloudCannon · Jun 29, 2024 · 000ab70 · 000ab70
1 parent 7baba43
commit 000ab70
Showing 1 changed file with 42 additions and 10 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -94,9 +94,25 @@ jobs:
     steps:
       - name: Clone
         uses: actions/checkout@v4
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: release-checksums
+          name: release-checksums-x86_64-pc-windows-msvc
+          path: wrappers/node/checksums
+      - uses: actions/download-artifact@v4
+        with:
+          name: release-checksums-x86_64-unknown-linux-musl
+          path: wrappers/node/checksums
+      - uses: actions/download-artifact@v4
+        with:
+          name: release-checksums-aarch64-unknown-linux-musl
+          path: wrappers/node/checksums
+      - uses: actions/download-artifact@v4
+        with:
+          name: release-checksums-x86_64-apple-darwin
+          path: wrappers/node/checksums
+      - uses: actions/download-artifact@v4
+        with:
+          name: release-checksums-aarch64-apple-darwin
           path: wrappers/node/checksums
 
       - name: Get Version
@@ -174,9 +190,9 @@ jobs:
     steps:
       - name: Clone
         uses: actions/checkout@v4
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
-          name: release
+          name: release-${{ matrix.target }}
           path: build-artifacts
 
       - name: Get Version
@@ -238,9 +254,25 @@ jobs:
       - name: Get Tag
         run: echo GIT_TAG="$(node ./.backstage/get_tag.cjs)" >> $GITHUB_ENV
 
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
+        with:
+          name: release-checksums-x86_64-pc-windows-msvc
+          path: build-artifacts
+      - uses: actions/download-artifact@v4
+        with:
+          name: release-checksums-x86_64-unknown-linux-musl
+          path: build-artifacts
+      - uses: actions/download-artifact@v4
+        with:
+          name: release-checksums-aarch64-unknown-linux-musl
+          path: build-artifacts
+      - uses: actions/download-artifact@v4
+        with:
+          name: release-checksums-x86_64-apple-darwin
+          path: build-artifacts
+      - uses: actions/download-artifact@v4
         with:
-          name: release
+          name: release-checksums-aarch64-apple-darwin
           path: build-artifacts
 
       - name: Build CHANGELOG
@@ -554,18 +586,18 @@ jobs:
           echo "EXTENDED_CHECKSUM_PATH=$CHECKSUM_PATH" >> $GITHUB_ENV
 
       - name: Upload build artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: release
+          name: release-${{ matrix.target }}
           path: |
             ${{ env.ASSET_PATH }}
             ${{ env.CHECKSUM_PATH }}
             ${{ env.EXTENDED_ASSET_PATH }}
             ${{ env.EXTENDED_CHECKSUM_PATH }}
       - name: Upload build artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: release-checksums
+          name: release-checksums-${{ matrix.target }}
           path: |
             ${{ env.CHECKSUM_PATH }}
             ${{ env.EXTENDED_CHECKSUM_PATH }}