Allow Xframe request from cloudcv.org #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deshraj
reviewed
Aug 13, 2018
demo/settings.py
Outdated
| @@ -102,3 +102,5 @@ | |||
| "ROUTING": "grad_cam.routing.channel_routing", | |||
| }, | |||
| } | |||
|
|
|||
| X_FRAME_OPTIONS = 'https://cloudcv.org/projects/grad-cam' | |||
There was a problem hiding this comment.
I am not sure if this is going to work. Can you please point me to the relevant documentation for the same. Also, it would be nice to put some description in the PR. :)
There was a problem hiding this comment.
Here is the documentation: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options
Moreover, I tested it on my local before opening the PR by running the two demos on different ports say 8001 or 8005 and website on another port say 6003.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows this demo to be listed as an <iframe> on the https://cloudcv.org/ website under the projects section.
@deshraj Please review the PR.