Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Xframe request from cloudcv.org #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow Xframe request from cloudcv.org #17

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5622697
Allow Xframe request from cloudcv.org
RishabhJain2018 Aug 12, 2018
58fc526
Minor Fix
RishabhJain2018 Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions demo/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,5 @@
"ROUTING": "grad_cam.routing.channel_routing",
},
}

X_FRAME_OPTIONS = 'https://cloudcv.org/projects/grad-cam'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is going to work. Can you please point me to the relevant documentation for the same. Also, it would be nice to put some description in the PR. :)

Copy link
Member Author

@RishabhJain2018 RishabhJain2018 Aug 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the documentation: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options
Moreover, I tested it on my local before opening the PR by running the two demos on different ports say 8001 or 8005 and website on another port say 6003.