Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metabase 0.47 support, reworked base types mapping #181

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Metabase 0.47 support, reworked base types mapping #181

merged 4 commits into from
Aug 1, 2023

Conversation

slvrtrn
Copy link
Collaborator

@slvrtrn slvrtrn commented Aug 1, 2023 •
edited
Loading

Summary

  • Metabase 0.47 support
  • Connection impersonation support (0.47 feature)
  • DateTime64 is now correctly mapped to :type/DateTime
  • General database type -> base type mapping rework (some test scenarios were taken from https://regex101.com/r/Yahlbt/1, props to @mlosnikov)

Resolves #177
Resolves #178
Resolves #179

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

dodg3this and others added 2 commits July 11, 2023 16:58
@dodg3this @slvrtrn
Replace the usage of u/snake-key with u/->snake_case_en (#160)
aff5443 
* replace the usage of u/snake-key with u/->snake_case_en

* Update check.yml

---------

Co-authored-by: Serge Klochkov <[email protected]>
@slvrtrn
Metabase 0.47 support, reworked base types mapping
9de5ad6
@slvrtrn slvrtrn requested a review from mshustov August 1, 2023 00:21
@slvrtrn slvrtrn self-assigned this Aug 1, 2023
@slvrtrn slvrtrn mentioned this pull request Aug 1, 2023
Closed
3 tasks
mshustov
mshustov approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 💪

@slvrtrn slvrtrn merged commit 6f07f69 into master Aug 1, 2023
@slvrtrn slvrtrn deleted the metabase-0.47 branch August 1, 2023 15:18
@slvrtrn slvrtrn mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

Assignees

@slvrtrn slvrtrn

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@slvrtrn @mshustov @dodg3this