feature: Add DateTime with timezone support #154
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Metabase builder generates condition like this on DateTime column even if local timezone is enabled:
column_name >= parseDateTimeBestEffort('2023-03-13 00:00:00.000Z')
For comparison, with Postgres it looks like this:
"column_name" >= timestamp with time zone '2023-03-13 00:00:00.000-04:00'
This PR just extends regex for column mapping to properly handle columns with type
DateTime('Timezone')
Some tests with this regex:
https://regex101.com/r/Yahlbt/1
Checklist
Delete items not relevant to your PR: