Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python .../venv/bin/chia -> .../venv/bin/chia #2311

Merged
merged 1 commit into from
Mar 22, 2024
Merged

python .../venv/bin/chia -> .../venv/bin/chia #2311

merged 1 commit into from
Mar 22, 2024

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Mar 22, 2024 •
edited
Loading

Fixed issues found by Arvid in #2309

Test

I've tested all cases below again.
Also confirmed that Fedora39 issue has been fixed by this PR.

type OS version result Note
source m1 Mac 14.3.1 Sonoma OK
source Windows 10 OK
source Ubuntu 22.04 OK
source Fedora 39 OK
package m1 Mac 14.3.1 Sonoma OK
package Windows 10 OK
package Ubuntu 22.04 OK
package Fedora 39 OK

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Mar 22, 2024
@ChiaMineJP ChiaMineJP self-assigned this Mar 22, 2024
@ChiaMineJP ChiaMineJP mentioned this pull request Mar 22, 2024
Merged
@ChiaMineJP ChiaMineJP marked this pull request as draft March 22, 2024 13:56
@ChiaMineJP ChiaMineJP force-pushed the cmj.fix-daemon-launch2 branch from e2cc171 to 02d7340 Compare March 22, 2024 14:22
@ChiaMineJP ChiaMineJP requested review from seeden and arvidn March 22, 2024 14:23
@ChiaMineJP ChiaMineJP marked this pull request as ready for review March 22, 2024 14:24
@ChiaMineJP ChiaMineJP mentioned this pull request Mar 22, 2024
Merged
@seeden seeden merged commit c3e6838 into main Mar 22, 2024
9 checks passed
@seeden seeden deleted the cmj.fix-daemon-launch2 branch March 22, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn approved these changes

@seeden seeden Awaiting requested review from seeden

Assignees

@ChiaMineJP ChiaMineJP

Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChiaMineJP @arvidn @seeden