Changed the start-up file to launch daemon process #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiaMineJP
added
the
Fixed
seeden
approved these changes
Mar 22, 2024
arvidn
reviewed
Mar 22, 2024
| pyProc = new Process(script, ['--wait-for-unlock'], processOptions); | ||
| } | ||
| const Process = childProcess.spawn; | ||
| pyProc = new Process(executablePath, PY_DIST_EXEC_ARGS); | ||
| } catch (e) { | ||
| console.info('Running python executable: Error: '); |
There was a problem hiding this comment.
shouldn't you print e here as well?
I suppose you're not changing this though
| if (guessPackaged()) { | ||
| const executablePath = getExecutablePath(PY_DIST_EXECUTABLE); | ||
| console.info('Running python executable: '); |
There was a problem hiding this comment.
is "python executable" accurate? afaict, the file ends with .exe on winows, and there's no python prefix to the command line
There was a problem hiding this comment.
Fixed in Fixed in #2311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed the start-up file to launch daemon process.
Previously:
.../app.asar.unpacked/daemon/daemon(for source install,python .../chia/daemon/server.py)Now:
.../app.asar.unpacked/daemon/chia start daemon(for source install,.../venv/bin/chia start daemon)This PR makes use of
chia start daemoncommand instead ofdaemon/server.pyto launch adaemonprocessTest
(*1) About Fedora39 issue (source install)
This issue persistes from the previous releases so not a new issue.
In order to launch daemon from the GUI, you need to set values to
PYTHONPATH.The values should be source root directory where you clone
chia-blockchain.For example, if you clone
chia-blockchainbythen you need to set PYTHONPATH like
PYTHONPATH=/home/user/dev/chia-blockchain:/home/user/dev/chia-blockchain/venv/lib/python-3.12/site-packages