-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](mlu-ops): add dcn_forward and dcn_backward_weight op #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SangChengC
force-pushed
the
binary-dcn-sangcm
branch
9 times, most recently
from
January 15, 2024 09:58
c0229c5
to
cea9549
Compare
mahxn0
approved these changes
Jan 15, 2024
SangChengC
force-pushed
the
binary-dcn-sangcm
branch
2 times, most recently
from
January 15, 2024 12:05
3a4e9ee
to
9657a62
Compare
Unireverse
reviewed
Jan 15, 2024
PetrelYy
reviewed
Jan 15, 2024
DanieeelLiu
reviewed
Jan 15, 2024
PetrelYy
reviewed
Jan 15, 2024
PetrelYy
reviewed
Jan 15, 2024
test/mlu_op_gtest/pb_gtest/src/internal_kernel/transpose_cpu/transpose_cpu.cpp
Show resolved
Hide resolved
PetrelYy
reviewed
Jan 15, 2024
test/mlu_op_gtest/pb_gtest/src/internal_kernel/transpose_cpu/transpose_cpu.h
Outdated
Show resolved
Hide resolved
Unireverse
reviewed
Jan 15, 2024
Unireverse
reviewed
Jan 15, 2024
PetrelYy
reviewed
Jan 15, 2024
test/mlu_op_gtest/pb_gtest/src/internal_kernel/transpose_cpu/transpose_cpu.cpp
Outdated
Show resolved
Hide resolved
Unireverse
reviewed
Jan 15, 2024
Unireverse
reviewed
Jan 15, 2024
test/mlu_op_gtest/pb_gtest/src/internal_kernel/transpose_cpu/transpose_cpu.cpp
Outdated
Show resolved
Hide resolved
SangChengC
force-pushed
the
binary-dcn-sangcm
branch
2 times, most recently
from
January 15, 2024 12:53
13b0564
to
f0ce388
Compare
mahxn0
reviewed
Jan 15, 2024
test/mlu_op_gtest/pb_gtest/src/internal_kernel/transpose_cpu/transpose_cpu.cpp
Outdated
Show resolved
Hide resolved
test/mlu_op_gtest/pb_gtest/src/internal_kernel/transpose_cpu/transpose_cpu.cpp
Outdated
Show resolved
Hide resolved
test/mlu_op_gtest/pb_gtest/src/zoo/dcn_forward/test_case/case_hi_16.prototxt
Outdated
Show resolved
Hide resolved
test/mlu_op_gtest/pb_gtest/src/zoo/dcn_backward_weight/test_case/case_hi_16.prototxt
Outdated
Show resolved
Hide resolved
test/mlu_op_gtest/pb_gtest/src/zoo/dcn_backward_weight/test_case/case_hi_16.prototxt
Outdated
Show resolved
Hide resolved
mahxn0
approved these changes
Jan 15, 2024
SangChengC
force-pushed
the
binary-dcn-sangcm
branch
from
January 16, 2024 08:13
f0ce388
to
3012dbd
Compare
SangChengC
force-pushed
the
binary-dcn-sangcm
branch
2 times, most recently
from
January 16, 2024 08:18
462167e
to
e7bf9e6
Compare
SangChengC
force-pushed
the
binary-dcn-sangcm
branch
2 times, most recently
from
January 16, 2024 12:03
c56aef1
to
4ed9c02
Compare
AquamarineSu
approved these changes
Jan 17, 2024
mahxn0
approved these changes
Jan 17, 2024
Unireverse
approved these changes
Jan 17, 2024
duzekunKTH
reviewed
Jan 17, 2024
SangChengC
force-pushed
the
binary-dcn-sangcm
branch
from
January 17, 2024 03:41
4ed9c02
to
0d2eaf0
Compare
DanieeelLiu
reviewed
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. 🚀🚀
1. Motivation
add dcn_forward and dcn_backward_weight op
2. Modification
3. Test Report
If you want to know how to do operator testing, you can see GTest-User-Guide-zh.
3.1 Modification Details
3.1.1 Accuracy Acceptance Standard
For static threshold standard details, see: MLU-OPS Accuracy Acceptance Standard.
3.1.2 Operator Scheme checklist
3.2 Accuracy Test
3.2.1 Accuracy Test
If you have checked the following items, please tick the relevant box.
3.2.2 Parameter Check
Test Point-1:
When a new operator is submitted, the test points are given and the test results are stated
. Acceptance Standard:Normal error
.Test Point-2:
Whether illegal parameters are passed
. Acceptance Standard:Normal error
.3.3 Performance Test
See MLU-OPS Performance Acceptance Standard for details.
Platform:MLU370
Platform:MLU590
3.4 Summary Analysis
Please give a brief overview here, if you want to note and summarize the content.