Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update hugr dependency #535

Merged
merged 5 commits into from
Aug 13, 2024
Merged

chore: Update hugr dependency #535

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c48bb6d
chore: Update hugr dependency
croyzor Aug 13, 2024
15b831d
Bump minimum version
croyzor Aug 13, 2024
bf0ed49
Revert "Bump minimum version"
croyzor Aug 13, 2024
0cfeabf
Update lock file
croyzor Aug 13, 2024
8710f56
chore: Update rust hugr dependency
croyzor Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ license = { file = "LICENCE" }
# Note: Be sure to update the dependency versions in [tool.poetry.dependencies] as well
dependencies = [
'pytket >= 1.29.2, < 2',
'hugr >= 0.5.0, < 0.6',
'hugr >= 0.5.0, < 0.7',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • See the Note just above
  • Should this be >= 0.6.0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the policy to only support one version of hugr? I figured I'd keep 0.5.0 as the minimum bound since it still works, but I'm happy either way

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main problem rn is serialisation, since we dropped the compatibility assurance.

I'd also check if we don't need to update the rust version too, for the same reason :/
(have we broken serialisation on the hugr-rs 0.11 release?)

'tket2_eccs >= 0.1.0, < 0.2',
]

Expand Down
Loading