-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update hugr dependency #535
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 83.09% 83.93% +0.83%
==========================================
Files 45 61 +16
Lines 6206 6696 +490
Branches 6206 6202 -4
==========================================
+ Hits 5157 5620 +463
- Misses 768 794 +26
- Partials 281 282 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit 15b831d.
pyproject.toml
Outdated
# Note: Be sure to update the dependency versions in [tool.poetry.dependencies] as well | ||
dependencies = [ | ||
'pytket >= 1.29.2, < 2', | ||
'hugr >= 0.5.0, < 0.6', | ||
'hugr >= 0.5.0, < 0.7', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See the
Note
just above - Should this be
>= 0.6.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the policy to only support one version of hugr? I figured I'd keep 0.5.0 as the minimum bound since it still works, but I'm happy either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main problem rn is serialisation, since we dropped the compatibility assurance.
I'd also check if we don't need to update the rust version too, for the same reason :/
(have we broken serialisation on the hugr-rs 0.11
release?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Update the version of hugr used by the rust and python code.
The main API difference is that extensions must be declared with explicit versions.
BEGIN_COMMIT_OVERRIDE
chore!: Update hugr dependency
END_COMMIT_OVERRIDE