Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update hugr dependency #535

Merged
merged 5 commits into from
Aug 13, 2024
Merged

chore: Update hugr dependency #535

merged 5 commits into from
Aug 13, 2024

Conversation

croyzor
Copy link
Contributor

@croyzor croyzor commented Aug 13, 2024

Update the version of hugr used by the rust and python code.
The main API difference is that extensions must be declared with explicit versions.

BEGIN_COMMIT_OVERRIDE
chore!: Update hugr dependency
END_COMMIT_OVERRIDE

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (ff46873) to head (8710f56).

Files Patch % Lines
tket2/src/passes/pytket.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
+ Coverage   83.09%   83.93%   +0.83%     
==========================================
  Files          45       61      +16     
  Lines        6206     6696     +490     
  Branches     6206     6202       -4     
==========================================
+ Hits         5157     5620     +463     
- Misses        768      794      +26     
- Partials      281      282       +1     
Flag Coverage Δ
python 95.34% <ø> (?)
rust 83.02% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@croyzor croyzor requested a review from aborgna-q August 13, 2024 09:49
@croyzor croyzor marked this pull request as ready for review August 13, 2024 09:49
@croyzor croyzor requested a review from a team as a code owner August 13, 2024 09:49
pyproject.toml Outdated
Comment on lines 77 to 80
# Note: Be sure to update the dependency versions in [tool.poetry.dependencies] as well
dependencies = [
'pytket >= 1.29.2, < 2',
'hugr >= 0.5.0, < 0.6',
'hugr >= 0.5.0, < 0.7',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • See the Note just above
  • Should this be >= 0.6.0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the policy to only support one version of hugr? I figured I'd keep 0.5.0 as the minimum bound since it still works, but I'm happy either way

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main problem rn is serialisation, since we dropped the compatibility assurance.

I'd also check if we don't need to update the rust version too, for the same reason :/
(have we broken serialisation on the hugr-rs 0.11 release?)

@croyzor croyzor changed the title chore: Update hugr dependency chore: Update hugr dependency upper bound Aug 13, 2024
@croyzor croyzor changed the title chore: Update hugr dependency upper bound chore: Update hugr dependency Aug 13, 2024
@croyzor croyzor requested a review from aborgna-q August 13, 2024 13:16
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@croyzor croyzor added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 0196fdd Aug 13, 2024
17 of 19 checks passed
@croyzor croyzor deleted the chore/update-hugr branch August 13, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants