fix: Warn user about implicit qubit permutations in tk_to_qiskit
#412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMacCQ
commented
Nov 7, 2024
| def test_implicit_swap_warning() -> None: | ||
| c = Circuit(2).H(0).SWAP(0, 1) | ||
| c.replace_SWAPs() | ||
| with pytest.warns(UserWarning, match="The pytket Circuit contains implicit qubit"): |
There was a problem hiding this comment.
Kindof suprised that python can use this UserWarning class without it being imported.
I guess errors like NotImplementedError don't need to be imported either so its not so surprising.
cqc-alec
requested changes
Nov 8, 2024
| @@ -855,6 +856,11 @@ def append_tk_command_to_qiskit( | |||
| supported_gate_rebase = AutoRebase(_protected_tket_gates) | |||
|
|
|||
|
|
|||
| def _has_implicit_permutation(circ: Circuit) -> bool: | |||
There was a problem hiding this comment.
This would be better defined in pytket rather than this extension: there's nothing specific to qiskit about it. But for now there is no need to factor it out as a method, since it's only used in one place.
There was a problem hiding this comment.
Agreed. Maybe it should just be a property/method of Circuit.
There was a problem hiding this comment.
Yes. But for the purpose of this PR the check can just be inlined.
Co-authored-by: Alec Edgington <[email protected]>
cqc-alec
approved these changes
Nov 8, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor change to
tk_to_qiskit. The user now gets a warning if the input pytketCircuitcontains implicit qubit permutations.closes #411
Related issues
#411
Checklist