-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix brisbane not working with ibmq_qasm_simulator anymore #287
Conversation
tests/backend_test.py
Outdated
@@ -857,8 +857,8 @@ def test_ibmq_emulator( | |||
|
|||
c_cop_2 = c.copy() | |||
c_cop_2 = b_aer.get_compiled_circuit(c_cop_2, ol) | |||
if ol == 0: | |||
assert not all(pred.verify(c_cop_2) for pred in b.required_predicates) | |||
# if ol == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The circuit is already fully supported by the simulator without compilation, so this test fails with the change
Ready for review. |
What exactly is the issue with |
This difference is that this testcase is the only test using the backend and compiling the circuit with one of the default compilation passes. All other testcases are running uncompiled circuits. |
When running this with the |
These both seem to indicate a bug in the compilation:
|
The IBMQEmulatorBackend is using the gateset, architecture, noisemodel and compilation passes of the real device, in our case the IBMQBackend. The IBMQEmulatorBackend is then always running the circuit on the simulator without additional compilation or checks. We could add that, but not sure how much would be left from the original device after that. |
Ah so the simulator doesn't support the ECR gate but the device does? I see. Maybe we should raise this issue with IBM? It would be useful if the simulator supported all the gates that the devices do. Still not sure why we are compiling to a 51-qubit circuit? |
2bc3c72
to
5df19e5
Compare
@cqc-alec this is currently not showing up on develop, but I am not sure why. I would keep this open and wait a few days? |
Description
All devices available in the open plan have more then the 32 qubits that are supported by the ibmq_qasm_simulator. So we need to replace them. Not sure what the best strategy is...
Related issues
Please mention any github issues addressed by this PR.
Checklist