remove remote simulator #301
Conversation
| @@ -95,7 +94,7 @@ to disk: | |||
| IBMProvider.save_account(token=ibm_token) | |||
| QiskitRuntimeService.save_account(channel="ibm_quantum", token=ibm_token) | |||
|
|
|||
| To see which devices you can access you can use the ``available_devices`` method on the :py:class:`IBMQBackend` or :py:class:`IBMQEmulatorBackend`. Note that it is possible to pass optional ``instance`` and ``provider`` arguments to this method. This allows you to see which devices are accessible through your IBM hub. | |||
There was a problem hiding this comment.
The local emulator was not listed here? Is this functionality available with the local setup?
There was a problem hiding this comment.
The local emulator was not listed here? Is this functionality available with the local setup?
No, it's just a class method on IBMQBackend.
|
I have tried to slip up the changes into different commits, looking at them separately might be helpful in the review. |
tests/backend_test.py
Outdated
| for b in [brisbane_emulator_backend, brisbane_local_emulator_backend]: | ||
| assert b._noise_model is not None # type: ignore | ||
| b_ibm = b._ibmq # type: ignore | ||
| for b in [brisbane_local_emulator_backend]: |
There was a problem hiding this comment.
No need for a for loop here now.
tests/backend_test.py
Outdated
| ) -> None: | ||
| # https://github.com/CQCL/pytket-qiskit/issues/93 | ||
| for b in [brisbane_emulator_backend, brisbane_local_emulator_backend]: | ||
| for b in [brisbane_local_emulator_backend]: |
| @@ -1113,62 +1110,6 @@ def test_postprocess() -> None: | |||
| b.cancel(h) | |||
|
|
|||
|
|
|||
| @pytest.mark.flaky(reruns=3, reruns_delay=10) | |||
| @pytest.mark.skipif(skip_remote_tests, reason=REASON) | |||
| def test_postprocess_emu(ibmq_qasm_emulator_backend: IBMQEmulatorBackend) -> None: | |||
There was a problem hiding this comment.
Can we make IBMQLocalEmulatorBackend support contextual optimization in the same way that IBMQEmulatorBackend did? Or make a new issue for this.
There was a problem hiding this comment.
I have added an issue for that #302
I will try to do this later today, would you be fine with doing a release without this?
There was a problem hiding this comment.
If we rename this file to ibmq_emulator.py is that going to confuse git?
There was a problem hiding this comment.
I have done this now in a separate commit, if you don't try to review all changes at once it should be fine.
Done in 12eb951
tests/conftest.py
Outdated
|
|
||
| @pytest.fixture(scope="module") | ||
| def ibmq_qasm_emulator_backend() -> IBMQEmulatorBackend: | ||
| def brisbane_local_emulator_backend() -> IBMQEmulatorBackend: |
There was a problem hiding this comment.
Can we rename this to brisbane_emulator_backend, since we're dropping "local".
| @@ -5,6 +5,8 @@ Unreleased | |||
| ---------- | |||
|
|
|||
| * Update qiskit-ibm-runtime version requirement to 0.22. | |||
| * remove all remote simulators | |||
| * rename ``IBMQLocalEmulatorBackend`` to ``IBMQEmulatorBackend`` | |||
There was a problem hiding this comment.
Maybe add that simulatons that used IBMQEmulatorBackend previously will now run locally. Just to be explcit.
Description
Remove all the remote simulators
Related issues
Solves #300 #278 #272 #231 #287
Checklist