-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Qiskit 1.0 #279
Merged
cqc-melf
merged 9 commits into
CQCL:feature/update-qiskit-1-0-0
from
frankharkins:FH/qiskit-1.0
Mar 4, 2024
Merged
Update for Qiskit 1.0 #279
cqc-melf
merged 9 commits into
CQCL:feature/update-qiskit-1-0-0
from
frankharkins:FH/qiskit-1.0
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankharkins
commented
Mar 4, 2024
Thank you for this PR @frankharkins ! Very helpful! There are a few issues with the format checks, I am happy to clean that up |
Thanks for the review! Hopefully that fixed it. Do feel free to push to this branch if needed though. |
We are not running all checks on PRs from extern, I will merge this now into a different branch, run the checks and then hopefully merge it into develop. Thanks again for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the minimal changes needed to get the tests working with Qiskit 1.0. It's possible this is all that's needed for full compatibility, but I'm not familiar with the repo so am just relying on getting the tests passing.
Most changes are just find/replace, the only exception being a tweak to
add_qiskit_data
to handle some removed attributes ofClbit
.Related issues
Closes #263 .
Checklist