Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Qiskit 1.0 #279

Merged

Conversation

frankharkins
Copy link
Contributor

@frankharkins frankharkins commented Mar 4, 2024

Description

This PR makes the minimal changes needed to get the tests working with Qiskit 1.0. It's possible this is all that's needed for full compatibility, but I'm not familiar with the repo so am just relying on getting the tests passing.

Most changes are just find/replace, the only exception being a tweak to add_qiskit_data to handle some removed attributes of Clbit.

Related issues

Closes #263 .

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@frankharkins frankharkins requested a review from cqc-melf as a code owner March 4, 2024 13:47
docs/changelog.rst Outdated Show resolved Hide resolved
@cqc-melf
Copy link
Collaborator

cqc-melf commented Mar 4, 2024

Thank you for this PR @frankharkins ! Very helpful!

There are a few issues with the format checks, I am happy to clean that up

@frankharkins
Copy link
Contributor Author

frankharkins commented Mar 4, 2024

Thanks for the review! Hopefully that fixed it. Do feel free to push to this branch if needed though.

@cqc-melf cqc-melf changed the base branch from develop to feature/update-qiskit-1-0-0 March 4, 2024 15:50
@cqc-melf
Copy link
Collaborator

cqc-melf commented Mar 4, 2024

We are not running all checks on PRs from extern, I will merge this now into a different branch, run the checks and then hopefully merge it into develop. Thanks again for the help!

@cqc-melf cqc-melf merged commit 519926c into CQCL:feature/update-qiskit-1-0-0 Mar 4, 2024
7 checks passed
@frankharkins frankharkins deleted the FH/qiskit-1.0 branch March 4, 2024 16:28
@cqc-melf cqc-melf mentioned this pull request Mar 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to qiskit 1.0
3 participants