update qiskit 1 0 0 #280
Merged
update qiskit 1 0 0 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for Qiskit 1.0
cqc-melf
commented
Mar 4, 2024
cqc-melf
commented
Mar 4, 2024
cqc-melf
commented
Mar 4, 2024
cqc-alec
requested changes
Mar 5, 2024
Co-authored-by: Alec Edgington <[email protected]>
cqc-alec
previously approved these changes
Mar 5, 2024
CalMacCQ
previously approved these changes
Mar 5, 2024
| @@ -80,8 +80,8 @@ | |||
| ) | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from qiskit.providers.aer import AerJob # type: ignore | |||
| from qiskit.providers.aer.backends.aerbackend import AerBackend as QiskitAerBackend # type: ignore | |||
| from qiskit_aer import AerJob | |||
There was a problem hiding this comment.
Does AerJob still need to be inside the if TYPE_CHECKING:?
There was a problem hiding this comment.
From my understanding we are not using it besides type annotations?
There was a problem hiding this comment.
Ah okay, that seems fine to me then :)
|
Needed to change the backbend in the not working test. Hope it works now. |
CalMacCQ
approved these changes
Mar 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reopen #279 to run the tests
Checklist