docs(spec): Add note on serialized hugr node order #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croyzor
commented
Feb 27, 2024
| @@ -1556,8 +1556,8 @@ pseudocode, though we advocate MessagePack format in practice (see | |||
| [Serialization implementation](schema/serialization.md)). | |||
| Note in particular that hierarchical relationships | |||
| have a special encoding outside `edges`, as a field `parent` | |||
| in a node definition. | |||
| The unique root node of the HUGR reports itself as the parent. | |||
| in a node definition. Nodes are identified by their position in the `nodes` | |||
There was a problem hiding this comment.
This is already said below, but I think it bears repeating because it's not super intuitive. I'd be glad to hear a rewording that makes it clearer though
There was a problem hiding this comment.
The wording sounds good to me. Maybe we should also clarify that the position is zero-based?
aborgna-q
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
+ Coverage 84.04% 84.20% +0.16%
==========================================
Files 77 78 +1
Lines 14234 14280 +46
Branches 14234 14280 +46
==========================================
+ Hits 11963 12025 +62
+ Misses 1435 1420 -15
+ Partials 836 835 -1 ☔ View full report in Codecov by Sentry. |
mark-koch
approved these changes
Mar 6, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.