Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the ordering of different edge kinds in the spec #848

Open
croyzor opened this issue Feb 27, 2024 · 2 comments
Open

Specify the ordering of different edge kinds in the spec #848

croyzor opened this issue Feb 27, 2024 · 2 comments
Assignees
@zrho
Labels
spec Issues to do with the specification document(s)

Comments

@croyzor
Copy link
Contributor

croyzor commented Feb 27, 2024 •
edited
Loading

When serializing/deserializing a hugr, Value edges should come before non-dataflow edges, but what order should the non-dataflow edges come in? I.e. if a node takes a StateOrder edge and a Static edge, what order should they appear in?
@croyzor
Copy link
Contributor Author

croyzor commented Feb 27, 2024

Looking at ops.rs, it seems like nodes can only have one non-dataflow edge, referred to as other_input/other_output. That solves the problem, but seems inflexible

@aborgna-q aborgna-q linked a pull request Feb 27, 2024 that will close this issue
docs(spec): Add note on serialized hugr node order #849
Merged
@aborgna-q aborgna-q removed a link to a pull request Feb 27, 2024
docs(spec): Add note on serialized hugr node order #849
Merged
@doug-q
Copy link
Collaborator

doug-q commented Mar 4, 2024 •
edited
Loading

It's not the case that ops can only have one non-dataflow edge. DataflowBlocks can have any number of CFG edges. LoadConstant can have both a static edge and an order edge.

EDIT: I don't think LoadConstant can have an order edge, but see linked issue.

@croyzor croyzor self-assigned this Mar 6, 2024
@aborgna-q aborgna-q added the spec Issues to do with the specification document(s) label May 15, 2024
@doug-q doug-q mentioned this issue Jun 6, 2024
Closed
@ss2165 ss2165 mentioned this issue Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zrho zrho

Labels
spec Issues to do with the specification document(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zrho @croyzor @aborgna-q @doug-q