-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new] Infer extension requirements #330
Merged
Merged
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
dbac242
[broken] Add unification module
croyzor 02af3dd
[broken] towards compiling unification
croyzor edc304e
[cosmetic] Renumber variables in unification test
croyzor 664d318
[doc] Add a couple of comments
croyzor 689cb85
[fix] Give variables unique names
croyzor 11517f3
[new] Flesh out unification implementation
croyzor 3fde309
[new] Repeat unification until we stop making progress
croyzor 07fd0a1
[cosmetic] cargo fmt
croyzor 649b405
[cleanup] Remove hugr param from UnificationContext
croyzor e919030
[refactor] Clippy
croyzor 2b67370
[cleanup] Remove unused error
croyzor 685a802
[doc] Add a couple more comments
croyzor a25b32a
[new] Add method for getting I/O nodes from a HugrView
croyzor 98dd7a0
[new] Add resource inference as a hugr method & builder step
croyzor 638bc36
[doc] Add a couple of comments
croyzor 8547391
[refactor] Make gen_union_constraints it's own function
croyzor 0c39a2d
[new] I/O Constraints
croyzor d3c9cdf
[fix] Check if metas have been shunted before using them
croyzor f90c710
[refactor] Make result gathering its own function
croyzor 8c239af
[cosmetic] Cargo fmt
croyzor ae707a4
[fix] I/O constraints should be generated first
croyzor fa629f8
[refactor] Count names seperately from constraints
croyzor 75ad62b
[new] The rest of the owl
croyzor 88d0882
[doc] Documentation; privatisation
croyzor 78bf7d2
[cleanup] Cleanup and compile
croyzor 599c563
[tests] Remove failing "reverse" test for now
croyzor 6bd9ec1
[tests] Update validation tests
croyzor fa729ca
[tests] Weaken constraints of missing_lift_node
croyzor 6190ad4
[tests] Name dangling_src test
croyzor 50ea46c
[fix] Handle new metas created by `coalesce`
croyzor 53e6f70
[fix] Only add equality constraints for edges with *dataflow*
croyzor 98af2d5
[refactor] Don't bother validating in builder
croyzor 38f5e44
[cleanup] Debugging
croyzor aa6b74a
[new] Return ResourceError when possible
croyzor f380c02
[cleanup] Cargo fmt, remove comment
croyzor fe76fcc
[tests] Do the harder `from_graph` case
croyzor 01c25d9
[cleanup] Fix imports
croyzor 7005b29
[cleanup] Unused variables and stuff
croyzor 3361285
[fix] Skip using ModuleBuilder in `lift_node`
croyzor 6a0183f
[cleanup] Remove `Exactly` constraint
croyzor 8713250
[doc] Add missing docstrings
croyzor 8859b55
[cosmetic] Clippy suggestions
croyzor c2b4636
[cosmetic] Rename module unify -> infer
croyzor 148edd3
Merge remote-tracking branch 'origin/main' into new/resource-inference
croyzor a3bf5bd
[cosmetic] Cargo fmt
croyzor 5015657
[tests] Remove; Rename; Comment
croyzor f9e508d
[cleanup] Remove `Ord` impl for Constraint
croyzor 29b22c8
[cleanup] Remove redundant comment
croyzor 42237b7
[doc] Update a couple of comments
croyzor 3f43d73
Merge remote-tracking branch 'origin/main' into new/resource-inference
croyzor 3746de4
[cleanup] Remove debugging printlns
croyzor 35fe1a3
[cosmetic] Rename coalesce -> merge_equal_metas
croyzor 35d9a6b
[doc] More comments
croyzor 5767300
[cleanup] Remove redundant variable
croyzor dad7361
assert -> dbg_assert
croyzor 06492f7
is_some -> if let
croyzor 38815c3
Fix comment grammar
croyzor 4116b71
assert -> debug_assert
croyzor ff49e34
dbg_assert -> debug_assert
croyzor ec00202
Merge remote-tracking branch 'origin/main' into new/resource-inference
croyzor 6f3ff29
[cleanup] Remove dead code/comments
croyzor df84772
[tests] Check solutions more in tests
croyzor 4789506
[refactor] Simplify merge_equal_metas
croyzor 9f1ce81
[refactor] Make a dedicated struct for `Meta`
croyzor 5b51ba1
[refactor] Address review comments
croyzor 90e0d93
[tests] Add test of resolve
croyzor ce3c309
[doc] update comment
croyzor 679ba38
[tests] Only run inference once in dangling_src test
croyzor 70082c1
[fix] Be more strict about what variables are
croyzor 4b606f8
[doc] Comment
croyzor d600c94
[refactor] Clippy suggestions
croyzor 90017e1
Merge remote-tracking branch 'origin/main' into new/resource-inference
croyzor b046589
[fix] Add deleted line
croyzor 90b6961
Clippy
croyzor fe5c9ec
feat: Extension validation can take a closure of solutions (#456)
croyzor 9912edd
[new] Solve `Plus` constraints in the other direction
croyzor f4567f9
[tests] Check solution in `from_graph` test
croyzor 63aa47b
[tests] Delete redundant test
croyzor 7a5a85d
[refactor] Privatise `EqGraph`
croyzor 3ddce12
[doc] Redo module comment
croyzor 92ff411
[refactor] Add new `ExtensionError` constructors without port info
croyzor c43fcfc
Remove meta from set of variables after it's been shunted
croyzor 41b40bc
[refactor] Remove redundant clone
croyzor f9d4f88
[refactor] Remove redundant clone
croyzor 18ad400
Merge remote-tracking branch 'origin/main' into new/resource-inference
croyzor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
dbg_assert -> debug_assert
- Loading branch information
commit ff49e341bc063cbfc60c540cf40d74be61386449
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise return the same Meta?
this looks like it can not terminate in case of cycle?