-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new] Infer extension requirements #330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croyzor
force-pushed
the
new/resource-inference
branch
from
August 2, 2023 09:23
1ec3c4c
to
6392dd6
Compare
croyzor
changed the title
[new] Infer resource requirements
[new] Infer extension requirements
Aug 21, 2023
Fixes #454. Return from extension inference an extra solution set, which instantiates all of the inference variables to the empty set, meaning metavariables which depend on them can be solved
ss2165
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one outstanding clone thing but otherwise looks good
src/extension/infer.rs
Outdated
// > mb = fresh_meta() | ||
// > add_constraint(mb, Plus(b, ma) | ||
// > add_constraint(output, Equal(mb)) | ||
for r in delta.iter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look like it has been done
lmondada
pushed a commit
that referenced
this pull request
Aug 28, 2023
Add a module `extension::infer`, which given a Hugr attempts to infer the resource requirements where they are left open. Addresses #425 --------- Co-authored-by: Seyon Sivarajah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a module
extension::infer
, which given a Hugr attempts to infer the resource requirements where they are left open.Addresses #425