Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make internals of int ops and the "int" CustomType more public. #1114

Merged
merged 4 commits into from
May 29, 2024

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented May 28, 2024

closes #1113.

@doug-q doug-q requested a review from a team as a code owner May 28, 2024 08:27
@doug-q doug-q requested review from zrho and mark-koch and removed request for zrho May 28, 2024 08:27
@doug-q
Copy link
Collaborator Author

doug-q commented May 28, 2024

Changed reviewer because @zrho is getting spammed, feel free to change back. Also, it took me three tries to get this onto the right github page, you're welcome for notifications :)

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (1dc14fa) to head (9f8e08f).

Current head 9f8e08f differs from pull request most recent head 239bb72

Please upload reports for the commit 239bb72 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1114   +/-   ##
=======================================
  Coverage   86.78%   86.79%           
=======================================
  Files          90       90           
  Lines       18546    18549    +3     
  Branches    18153    18156    +3     
=======================================
+ Hits        16095    16099    +4     
+ Misses       1606     1605    -1     
  Partials      845      845           
Flag Coverage Δ
rust 86.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mark-koch mark-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@doug-q doug-q enabled auto-merge May 29, 2024 07:12
@doug-q doug-q added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 20f642b May 29, 2024
13 of 16 checks passed
@doug-q doug-q deleted the doug/public-int-exts branch May 29, 2024 07:17
This was referenced May 28, 2024
@hugrbot hugrbot mentioned this pull request May 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 29, 2024
## 🤖 New release
* `hugr`: 0.4.0 -> 0.5.0
* `hugr-cli`: 0.1.0
* `hugr-core`: 0.1.0
* `hugr-passes`: 0.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

## 0.5.0 (2024-05-29)

### Bug Fixes

- Missing re-exports in `hugr::hugr`
([#1127](#1127))
- Set initial version of hugr-core to 0.1.0
([#1129](#1129))

### Features

- [**breaking**] Remove `PartialEq` impl for `ConstF64`
([#1079](#1079))
- [**breaking**] Allow "Row Variables" declared as List<Type>
([#804](#804))
- Hugr binary cli tool ([#1096](#1096))
- [**breaking**] Move passes from `algorithms` into a separate crate
([#1100](#1100))
- [**breaking**] Disallow nonlocal value edges into FuncDefn's
([#1061](#1061))
- [**breaking**] Move cli in to hugr-cli sub-crate
([#1107](#1107))
- Add verbosity, return `Hugr` from `run`.
([#1116](#1116))
- Unseal and make public the traits `HugrInternals` and
`HugrMutInternals` ([#1122](#1122))

### Refactor

- [**breaking**] No Ports in TypeRow
([#1087](#1087))
- Add a `hugr-core` crate
([#1108](#1108))
</blockquote>

## `hugr-core`
<blockquote>

## 0.1.0 (2024-05-29)

### Bug Fixes

- Set initial version of hugr-core to 0.1.0
([#1129](#1129))

### Features

- [**breaking**] Move cli in to hugr-cli sub-crate
([#1107](#1107))
- Make internals of int ops and the "int" CustomType more public.
([#1114](#1114))
- Unseal and make public the traits `HugrInternals` and
`HugrMutInternals` ([#1122](#1122))

### Refactor

- Add a `hugr-core` crate
([#1108](#1108))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Agustin Borgna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow introspection of int ops
2 participants