Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Wrap failing pre-commit command #1126

Merged
merged 1 commit into from
May 29, 2024
Merged

ci: Wrap failing pre-commit command #1126

merged 1 commit into from
May 29, 2024

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented May 29, 2024

pre-commit started failing to parse the cargo doc command;

cargo doc................................................................Failed
- hook id: cargo-doc
- exit code: 1

Executable `RUSTDOCFLAGS=-Dwarnings` not found

it may be related to a version update.

The solution, as we've done in other steps, is to wrap everything as a sh -c command.

@aborgna-q aborgna-q requested a review from cqc-alec May 29, 2024 10:18
@aborgna-q aborgna-q requested a review from a team as a code owner May 29, 2024 10:18
@aborgna-q aborgna-q changed the title Wrap failing pre-commit command ci: Wrap failing pre-commit command May 29, 2024
@aborgna-q aborgna-q added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit bbefc04 May 29, 2024
16 checks passed
@aborgna-q aborgna-q deleted the ab/fix-pre-commit branch May 29, 2024 10:50
@doug-q
Copy link
Collaborator

doug-q commented May 29, 2024

I snuck this change in in #1114. I thought I was helping, but here we are. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants