Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify /convert endpoint to create user folders (βœ“ Sandbox Passed) #10

Closed
wants to merge 1 commit into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Dec 7, 2023

PR Feedback (click)

  • πŸ‘ Sweep Did Well
  • πŸ‘Ž Sweep Needs Improvement

Description

This pull request modifies the /convert endpoint in the submission.py file to create user folders. It retrieves the Keycloak userid hash from the request data and checks if the user exists in the database based on the hash. If the user does not exist, it creates new directories in the "output" and "uploads" directories with the Keycloak userid hash.

Summary

  • Modified /convert endpoint in submission.py to create user folders
  • Retrieved Keycloak userid hash from request data
  • Checked if user exists in the database based on the hash
  • Created new directories in "output" and "uploads" directories with Keycloak userid hash

Fixes #7.


πŸŽ‰ Latest improvements to Sweep:

  • We just released a dashboard to track Sweep's progress on your issue in real-time, showing every stage of the process – from search to planning and coding.
  • Sweep uses OpenAI's latest Assistant API to plan code changes and modify code! This is 3x faster and significantly more reliable as it allows Sweep to edit code and validate the changes in tight iterations, the same way as a human would.

πŸ’‘ To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

Copy link
Contributor Author

sweep-ai bot commented Dec 7, 2023

Sandbox Executions

  • Running GitHub Actions for convertPheno_server/server/apis/submission.py βœ“
Check convertPheno_server/server/apis/submission.py with contents:

Ran GitHub Actions for e9133625019b0d7938efef29faed434bbd95e107:

Copy link
Contributor Author

sweep-ai bot commented Dec 7, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@IvoLeist
Copy link
Member

IvoLeist commented Dec 7, 2023

Took inspiration by sweep's suggestion and the implemented it on my own πŸš€

@IvoLeist IvoLeist closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
1 participant