-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: 즐찾 음식으로부터 음식 생성 메소드 구현 (#96) #97
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
30d3ed4
:sparkles: feat: 즐찾 음식으로 음식 생성 구현 (#96)
synoti21 7b33ec4
:sparkles: feat: 즐찾 음식으로부터 음식 생성 위한 dto 추가 (#96)
synoti21 e08d169
:sparkles: feat: 즐찾 음식으로부터 음식 생성 메소드 구현 (#96)
synoti21 6f11159
:white_check_mark: test: 음식 생성 메소드 구현 테스트 코드 작성 (#96)
synoti21 f655b43
:sparkles: feat: favoriteFood와 Food 연관관계 설정 (#96)
synoti21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
src/main/java/com/diareat/diareat/food/dto/CreateFoodFromFavoriteFoodDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package com.diareat.diareat.food.dto; | ||
|
||
import com.diareat.diareat.util.MessageUtil; | ||
import lombok.AllArgsConstructor; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
|
||
import javax.validation.constraints.NotNull; | ||
|
||
@Getter | ||
@NoArgsConstructor | ||
@AllArgsConstructor | ||
public class CreateFoodFromFavoriteFoodDto { | ||
@NotNull(message = MessageUtil.NOT_NULL) | ||
private Long userId; | ||
|
||
@NotNull(message = MessageUtil.NOT_NULL) | ||
private Long favoriteFoodId; | ||
|
||
public static CreateFoodFromFavoriteFoodDto of(Long userId, Long favoriteFoodId) { | ||
return new CreateFoodFromFavoriteFoodDto(userId, favoriteFoodId); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
누락된 로직 반영해주셔서 감사합니다! 다만 새로 태어난 food가 자신이 즐찾음식으로부터 태어났다는 것을 표현하기 위해, food.setFavoriteFood 메서드만 325 라인 아래에 한 줄 추가해주시면 될 것 같습니다!