Feat: 즐찾 음식으로부터 음식 생성 메소드 구현 (#96) #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
synoti21
commented
Nov 14, 2023
synoti21
commented
- 즐찾 음식으로부터 음식 생성 메소드 구현
- 테스트 코드 작성 및 통과 확인
- 새로운 api endpoint: /food/favorite/createfrom
- 새로운 dto: CreateFoodFromFavoriteFoodDto
win-luck
changed the title
win-luck
reviewed
Nov 15, 2023
Comment on lines
+322
to
325
| public Long createFoodFromFavoriteFood(CreateFoodFromFavoriteFoodDto createFoodFromFavoriteFoodDto) { | ||
| validateFavoriteFood(createFoodFromFavoriteFoodDto.getFavoriteFoodId(), createFoodFromFavoriteFoodDto.getUserId()); | ||
| FavoriteFood favoriteFood = getFavoriteFoodById(createFoodFromFavoriteFoodDto.getFavoriteFoodId()); | ||
| Food food = FavoriteFood.createFoodFromFavoriteFood(favoriteFood); |
There was a problem hiding this comment.
누락된 로직 반영해주셔서 감사합니다! 다만 새로 태어난 food가 자신이 즐찾음식으로부터 태어났다는 것을 표현하기 위해, food.setFavoriteFood 메서드만 325 라인 아래에 한 줄 추가해주시면 될 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.