-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ Refactor: FoodServiceTest Mock으로 리팩토링 (#29) #32
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c870e14
:recycle: refactor: testSaveAndGetFood() mocking (#29)
synoti21 30d7c11
:recycle: refactor: testUpdateFood() mocking (#29)
synoti21 2ec2700
:recycle: refactor: testDeleteFood() mocking (#29)
synoti21 2e85c3a
:recycle: refactor: User 확인을 위한 validateUser() 추가 (#29)
synoti21 48664db
:recycle: refactor: validateUser(), validateFood() 추가에 따른 testCode 수정…
synoti21 34f7762
:recycle: refactor: testSaveAndGetFavoriteFood() mocking (#29)
synoti21 76f95db
:recycle: refactor: testUpdateFavoriteFood() mocking (#29)
synoti21 7d3ee8b
:pencil2: fix: 잘못된 Exception Type 수정 (#29)
synoti21 200e5f3
:recycle: refactor: testDeleteFavoriteFood() mocking (#29)
synoti21 37042ae
:recycle: refactor: testNutritionSumByDate() mocking (#29)
synoti21 bbbedd7
:recycle: refactor: testNutritionSumByWeek(), testNutritionSumByMonth…
synoti21 2db260a
:recycle: refactor: getBest3FoodTest() mocking (#29)
synoti21 448cbe3
:recycle: refactor: getWorst3FoodsTest() mocking (#29)
synoti21 ffd4ecd
:recycle: refactor: 불필요한 의존성 제거 (#29)
synoti21 111c0f4
:recycle: refactor: 불필요한 라이브러리 제거 (#29)
synoti21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
보통 이렇게 두 가지 이상의 Service에서 같은 검증 로직을 공유하는 경우에는 util 패키지에 별도의 싱글톤 클래스를 선언하여 그 내부 메서드를 사용하는 방식을 채택하는 경우도 있습니다만, Service에 두개뿐이라 그렇게까지 할 필요는 없는 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조언 감사합니다!