✅ Refactor: FoodServiceTest Mock으로 리팩토링 (#29) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
synoti21
commented
Oct 15, 2023
synoti21
commented
- 모든 FoodService 테스트 코드 mocking 완료
- Food 엔티티에 setId() 추가
- validateUser(), validateFood(), validateFavoriteFood() 추가
win-luck
changed the title
win-luck
reviewed
Oct 15, 2023
Comment on lines
+210
to
+223
| private void validateUser(Long userId) { | ||
| if (!userRepository.existsById(userId)) | ||
| throw new UserException(ResponseCode.USER_NOT_FOUND); | ||
| } | ||
|
|
||
| private void validateFood(Long foodId) { | ||
| if (!foodRepository.existsById(foodId)) | ||
| throw new FoodException(ResponseCode.FOOD_NOT_FOUND); | ||
| } | ||
|
|
||
| private void validateFavoriteFood(Long favoriteFoodId) { | ||
| if (!favoriteFoodRepository.existsById(favoriteFoodId)) | ||
| throw new FavoriteException(ResponseCode.FAVORITE_NOT_FOUND); | ||
| } |
There was a problem hiding this comment.
보통 이렇게 두 가지 이상의 Service에서 같은 검증 로직을 공유하는 경우에는 util 패키지에 별도의 싱글톤 클래스를 선언하여 그 내부 메서드를 사용하는 방식을 채택하는 경우도 있습니다만, Service에 두개뿐이라 그렇게까지 할 필요는 없는 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.