Add bridging explanation #2410
Add bridging explanation #2410
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request involve significant updates to the documentation concerning the game bridge closure and asset management in the Eternum game. Key modifications include the introduction of new sections that clarify critical end-game information, the restructuring of existing content for improved readability, and the addition of specific warnings regarding resource management during the closure period. The updates aim to ensure players are well-informed about the consequences of their actions as the season ends. Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM. |
|
Failed to generate code suggestions for PR |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docs/pages/overview/bridging.mdx (2)
6-9: Fix typo in critical information sectionThere's a duplicate word "after" in the message.
- The Game Bridge **permanently** closes **48 hours** after after victory has been claimed. + The Game Bridge **permanently** closes **48 hours** after victory has been claimed.
68-72: Consider using standard markdown list formatWhile the content is accurate, using blockquotes for a numbered list is unconventional. Consider using standard markdown numbered list format for better consistency.
-> 1. Remove all liquidity from AMM pools **before** the season ends -> 2. Cancel all open orders on the Order Book **before** the season ends -> 3. Ensure all resource transfers to your Realm are completed **before** the season ends -> 4. Bridge out **$LORDS** and **Resources** from your Realm's balance within the 48-hour window +1. Remove all liquidity from AMM pools **before** the season ends +2. Cancel all open orders on the Order Book **before** the season ends +3. Ensure all resource transfers to your Realm are completed **before** the season ends +4. Bridge out **$LORDS** and **Resources** from your Realm's balance within the 48-hour window
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
docs/pages/overview/bridging.mdx(2 hunks)docs/pages/overview/disclaimer.mdx(1 hunks)
🔇 Additional comments (7)
docs/pages/overview/bridging.mdx (3)
17-26: LGTM! Clear and comprehensive warning section
The warning effectively communicates critical information about bridge closure and non-bridgeable resources.
59-64: LGTM! Clear enumeration of end-game actions
The section effectively outlines the immediate consequences and available actions during the countdown period.
73-79: LGTM! Clear and prominent final warning
The error callout effectively emphasizes the critical warnings about permanent asset loss.
docs/pages/overview/disclaimer.mdx (4)
30-38: LGTM! Clear presentation of disabled actions
The section effectively communicates the immediate impact of season end on game functionality.
39-48: LGTM! Comprehensive withdrawal window details
The section clearly outlines the withdrawal process and potential blocking conditions.
49-57: LGTM! Clear deadlines and consequences
The section effectively communicates both the permanence of asset locking and the separate deadlines for score registration and prize claiming.
58-60: LGTM! Helpful risk mitigation advice
The pro tip effectively encourages proactive risk management through early bridging.
Summary by CodeRabbit