Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIP-741] Grant V3 Permissions to Maxis and Emergency DAO Multisigs #1535

Merged
merged 31 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e31d463
chore: skeleton payloads for granting perms
gosuto-inzasheru Dec 2, 2024
06e6bb5
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 2, 2024
77d284d
Merge branch 'main' into chore/perms_v3
gosuto-inzasheru Dec 4, 2024
3ed9d1b
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 4, 2024
e7f2468
ci: typos in step names
gosuto-inzasheru Dec 4, 2024
53d4c51
ci: fix numpy by preventing installing numpy>=2.0.0
gosuto-inzasheru Dec 4, 2024
3e1eabc
feat: (draft) permissions mapping for v3 launch
gosuto-inzasheru Dec 4, 2024
dba920b
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 4, 2024
9826e6f
chore: add emergency actions ids for ethereum
gosuto-inzasheru Dec 5, 2024
7e9bad9
ci: v6 introduces breaking changes for our imports
gosuto-inzasheru Dec 5, 2024
0f7d4e4
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 5, 2024
b770b0a
fix: use double quotes
gosuto-inzasheru Dec 5, 2024
ad27baa
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 5, 2024
b26db01
fix: no quotes at all
gosuto-inzasheru Dec 5, 2024
cef0d1a
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 5, 2024
30e49ee
chore: add more perms
gosuto-inzasheru Dec 5, 2024
6fa7787
chore: more perms for both ethereum and gnosis
gosuto-inzasheru Dec 5, 2024
3fb63e2
fix: remove comments
gosuto-inzasheru Dec 5, 2024
b880e59
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 5, 2024
ddd1805
chore: add last missing perms
gosuto-inzasheru Dec 5, 2024
bcce7af
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 5, 2024
2c4f7f8
fix: pool permissions are not the same on gnosis
gosuto-inzasheru Dec 5, 2024
d1b694c
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 5, 2024
290c48b
chore: add stable pool disable as well
gosuto-inzasheru Dec 5, 2024
b52b259
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 5, 2024
ceb5dc3
chore: assign bip# and move to next week
gosuto-inzasheru Dec 5, 2024
aa5ee91
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 5, 2024
af66bac
fix: bip needs to be uppercase?
gosuto-inzasheru Dec 5, 2024
e1336b0
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 5, 2024
55bb116
chore: removed unused authorizer script json
gosuto-inzasheru Dec 9, 2024
8e845f3
Automated processing of Payload PR (validations, transformations, and…
gosuto-inzasheru Dec 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/run_auth_gen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ jobs:
~/.vvm
key: compiler-cache

- name: Setup Python 3.9
- name: Setup Python 3.10
uses: actions/setup-python@v5
with:
python-version: "3.10"

- name: Do Work
- name: Generate Add Permissions Payload
if: ${{ github.event.label.name == 'Generate Authorizer' }}
env:
WEB3_INFURA_PROJECT_ID: ${{ secrets.WEB3_INFURA_PROJECT_ID }}
Expand Down
49 changes: 49 additions & 0 deletions BIPs/2024-W50/[BIP-741] perms_v3_ethereum.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"version": "1.0",
"chainId": "1",
"createdAt": 1733113186182,
"meta": {
"name": "Transactions Batch",
"description": "",
"txBuilderVersion": "1.17.1",
"createdFromSafeAddress": "0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f",
"createdFromOwnerAddress": "",
"checksum": "0xc46efd8b96f120018f988078f43bb02636f72c6328af55088c746f607fad28f2"
},
"transactions": [
{
"to": "0xA331D84eC860Bf466b4CdCcFb4aC09a1B43F3aE6",
"value": "0",
"data": null,
"contractMethod": {
"inputs": [
{ "internalType": "bytes32[]", "name": "roles", "type": "bytes32[]" },
{ "internalType": "address", "name": "account", "type": "address" }
],
"name": "grantRoles",
"payable": false
},
"contractInputsValues": {
"roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c,0x31893078b6590802f57d29fae81f10113c336375df90db2aed0392af0c75d8d4,0x3bc669a22fd5eb10a81a9ab00e0cab660e6f703d7ae9185597386bbd2e849e3f,0x93100e2a70c799f7ba831633b6a5078fc649ca0c812caa633106f1948a819155,0x131f9541f99a187d0a0db49756fb64345dec624e21579355e25b8b5a1b40b45c,0x4071255a8a5c23dae545fa9427571cfd2cbc2f7e623e863ec2c917ed09074e43,0xf830de585800a430465649def91ee4e68e52ef19d8734b6836b9a2237853fc07,0xc1d77fef06a5acef26a30536474b98eb44840e5f17e86114c8aaa4274e206b3c,0xeeed27c13054947e3283c26fca5c34c2e514ef8caa98f1c6a6778c06f1d247da]",
"account": "0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e"
}
},
{
"to": "0xA331D84eC860Bf466b4CdCcFb4aC09a1B43F3aE6",
"value": "0",
"data": null,
"contractMethod": {
"inputs": [
{ "internalType": "bytes32[]", "name": "roles", "type": "bytes32[]" },
{ "internalType": "address", "name": "account", "type": "address" }
],
"name": "grantRoles",
"payable": false
},
"contractInputsValues": {
"roles": "[0x461c5a059d49bcf53ff00ff0d6fe644f40cc96ff9f6012e75ea70824dba5f886,0xa3cc69d3a95a1b4020228f384f292c33a2db8f395442b06805d5195609d66b4e,0xae26501f09c96de9e98977fff0d65a23cb22db73a58ddef38127af1a616cf272,0xa4443105bdb833cb364c9f76caa2adf3c6e62427cb693ffd6f1d8d7f44ad1bb5,0xe80d721d89f2236e9428bfba076cbbbb355faeb9d9b97b49890ebcf930d05bc9,0xf923c4af23349707476c28766c280b0178ab3c4ebfa546da8c25a546a066a2dc,0xb1539e3ebdcf854dedf819f6232d1e447cfb129f7bf572e70295fb998bd8c85e,0x03aef606b4b82495d96af41cf1ed84b739a1de2bfb37bc1c0cfde2c53cf096aa,0x130ac25c06d0a78c43cee16ed4147a8a2337d8dc08571f397ca9ac15e1fc2ec2,0x7b9f4d9b9d0380987936892409571a5e0b6e9b538806ac662699a305304bd15d,0x6832812101826d0b63748615617865e97f09b944c344d3bbd7d50b5be617eb16,0x2f54088e4f997de92b7bea3779089047980bab824c65d526fc075413ff373000,0xed6f8a5f0602534601834cae86e16a9424b7bf30c562d15bd781fbcd5026d9a1]",
"account": "0xA29F61256e948F3FB707b4b3B138C5cCb9EF9888"
}
}
]
}
34 changes: 34 additions & 0 deletions BIPs/2024-W50/[BIP-741] perms_v3_ethereum.report.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
FILENAME: `BIPs/2024-W50/[BIP-741] perms_v3_ethereum.json`
MULTISIG: `multisigs/dao (mainnet:0x10A19e7eE7d7F8a52822f6817de8ea18204F2e4f)`
COMMIT: `55bb116955e3b0842256bd41974bb689e57eef92`
CHAIN(S): `mainnet`
TENDERLY: [`🟩 SUCCESS`](https://www.tdly.co/shared/simulation/c248b9a2-8a1c-4c1a-a160-9d61b663d999)

```
+-----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| function | caller_name | caller_address | fx_paths | action_ids | bip | tx_index |
+-----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
| Authorizer/grantRoles | multisigs/maxi_omni | 0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e | 20241204-v3-vault/VaultAdmin/setStaticSwapFeePercentage(address,uint256) | 0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c | BIP-741 | 0 |
| | | | 20241204-v3-vault/ProtocolFeeController/setGlobalProtocolSwapFeePercentage(uint256) | 0x31893078b6590802f57d29fae81f10113c336375df90db2aed0392af0c75d8d4 | | |
| | | | 20241204-v3-vault/ProtocolFeeController/setGlobalProtocolYieldFeePercentage(uint256) | 0x3bc669a22fd5eb10a81a9ab00e0cab660e6f703d7ae9185597386bbd2e849e3f | | |
| | | | 20241204-v3-vault/ProtocolFeeController/setProtocolSwapFeePercentage(address,uint256) | 0x93100e2a70c799f7ba831633b6a5078fc649ca0c812caa633106f1948a819155 | | |
| | | | 20241204-v3-vault/ProtocolFeeController/setProtocolYieldFeePercentage(address,uint256) | 0x131f9541f99a187d0a0db49756fb64345dec624e21579355e25b8b5a1b40b45c | | |
| | | | 20241204-v3-vault/ProtocolFeeController/withdrawProtocolFees(address,address) | 0x4071255a8a5c23dae545fa9427571cfd2cbc2f7e623e863ec2c917ed09074e43 | | |
| | | | 20241204-v3-vault/ProtocolFeeController/withdrawProtocolFeesForToken(address,address,address) | 0xf830de585800a430465649def91ee4e68e52ef19d8734b6836b9a2237853fc07 | | |
| | | | 20241205-v3-stable-pool/StablePool/startAmplificationParameterUpdate(uint256,uint256) | 0xc1d77fef06a5acef26a30536474b98eb44840e5f17e86114c8aaa4274e206b3c | | |
| | | | 20241205-v3-stable-pool/StablePool/stopAmplificationParameterUpdate() | 0xeeed27c13054947e3283c26fca5c34c2e514ef8caa98f1c6a6778c06f1d247da | | |
| Authorizer/grantRoles | multisigs/emergency | 0xA29F61256e948F3FB707b4b3B138C5cCb9EF9888 | 20241204-v3-vault/VaultAdmin/pauseVault() | 0x461c5a059d49bcf53ff00ff0d6fe644f40cc96ff9f6012e75ea70824dba5f886 | BIP-741 | 1 |
| | | | 20241204-v3-vault/VaultAdmin/unpauseVault() | 0xa3cc69d3a95a1b4020228f384f292c33a2db8f395442b06805d5195609d66b4e | | |
| | | | 20241204-v3-vault/VaultAdmin/pausePool(address) | 0xae26501f09c96de9e98977fff0d65a23cb22db73a58ddef38127af1a616cf272 | | |
| | | | 20241204-v3-vault/VaultAdmin/unpausePool(address) | 0xa4443105bdb833cb364c9f76caa2adf3c6e62427cb693ffd6f1d8d7f44ad1bb5 | | |
| | | | 20241204-v3-vault/VaultAdmin/pauseVaultBuffers() | 0xe80d721d89f2236e9428bfba076cbbbb355faeb9d9b97b49890ebcf930d05bc9 | | |
| | | | 20241204-v3-vault/VaultAdmin/unpauseVaultBuffers() | 0xf923c4af23349707476c28766c280b0178ab3c4ebfa546da8c25a546a066a2dc | | |
| | | | 20241204-v3-vault/VaultAdmin/enableRecoveryMode(address) | 0xb1539e3ebdcf854dedf819f6232d1e447cfb129f7bf572e70295fb998bd8c85e | | |
| | | | 20241204-v3-vault/VaultAdmin/disableRecoveryMode(address) | 0x03aef606b4b82495d96af41cf1ed84b739a1de2bfb37bc1c0cfde2c53cf096aa | | |
| | | | 20241204-v3-vault/VaultAdmin/enableQuery() | 0x130ac25c06d0a78c43cee16ed4147a8a2337d8dc08571f397ca9ac15e1fc2ec2 | | |
| | | | 20241204-v3-vault/VaultAdmin/disableQuery() | 0x7b9f4d9b9d0380987936892409571a5e0b6e9b538806ac662699a305304bd15d | | |
| | | | 20241204-v3-vault/VaultAdmin/disableQueryPermanently() | 0x6832812101826d0b63748615617865e97f09b944c344d3bbd7d50b5be617eb16 | | |
| | | | 20241205-v3-stable-pool/StablePoolFactory/disable() | 0x2f54088e4f997de92b7bea3779089047980bab824c65d526fc075413ff373000 | | |
| | | | 20241205-v3-weighted-pool/WeightedPoolFactory/disable() | 0xed6f8a5f0602534601834cae86e16a9424b7bf30c562d15bd781fbcd5026d9a1 | | |
+-----------------------+---------------------+--------------------------------------------+-----------------------------------------------------------------------------------------------+--------------------------------------------------------------------+---------+----------+
```
49 changes: 49 additions & 0 deletions BIPs/2024-W50/[BIP-741] perms_v3_gnosis.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
{
"version": "1.0",
"chainId": "100",
"createdAt": 1733113567208,
"meta": {
"name": "Transactions Batch",
"description": "",
"txBuilderVersion": "1.17.1",
"createdFromSafeAddress": "0x2a5AEcE0bb9EfFD7608213AE1745873385515c18",
"createdFromOwnerAddress": "",
"checksum": "0x84b97dbe42ed2fb42adef45f5178f146b17ea392e708251e106c24c7685c3909"
},
"transactions": [
{
"to": "0xA331D84eC860Bf466b4CdCcFb4aC09a1B43F3aE6",
"value": "0",
"data": null,
"contractMethod": {
"inputs": [
{ "internalType": "bytes32[]", "name": "roles", "type": "bytes32[]" },
{ "internalType": "address", "name": "account", "type": "address" }
],
"name": "grantRoles",
"payable": false
},
"contractInputsValues": {
"roles": "[0x535f82655cb6a856d1452d97dc8e7b3393044c974f85cfcdd2c1d304c08ce34c,0x31893078b6590802f57d29fae81f10113c336375df90db2aed0392af0c75d8d4,0x3bc669a22fd5eb10a81a9ab00e0cab660e6f703d7ae9185597386bbd2e849e3f,0x93100e2a70c799f7ba831633b6a5078fc649ca0c812caa633106f1948a819155,0x131f9541f99a187d0a0db49756fb64345dec624e21579355e25b8b5a1b40b45c,0x4071255a8a5c23dae545fa9427571cfd2cbc2f7e623e863ec2c917ed09074e43,0xf830de585800a430465649def91ee4e68e52ef19d8734b6836b9a2237853fc07,0xd092c49bcc2e34f69b02005821b50d57632951029f4a20eb4fb8d6fcb2ef08a3,0x66a9e5de1de4dbcb0b1d3979ca06bd4bb8ba535a1f67873ed92779cfd976dcf0]",
"account": "0x9ff471F9f98F42E5151C7855fD1b5aa906b1AF7e"
}
},
{
"to": "0xA331D84eC860Bf466b4CdCcFb4aC09a1B43F3aE6",
"value": "0",
"data": null,
"contractMethod": {
"inputs": [
{ "internalType": "bytes32[]", "name": "roles", "type": "bytes32[]" },
{ "internalType": "address", "name": "account", "type": "address" }
],
"name": "grantRoles",
"payable": false
},
"contractInputsValues": {
"roles": "[0x461c5a059d49bcf53ff00ff0d6fe644f40cc96ff9f6012e75ea70824dba5f886,0xa3cc69d3a95a1b4020228f384f292c33a2db8f395442b06805d5195609d66b4e,0xae26501f09c96de9e98977fff0d65a23cb22db73a58ddef38127af1a616cf272,0xa4443105bdb833cb364c9f76caa2adf3c6e62427cb693ffd6f1d8d7f44ad1bb5,0xe80d721d89f2236e9428bfba076cbbbb355faeb9d9b97b49890ebcf930d05bc9,0xf923c4af23349707476c28766c280b0178ab3c4ebfa546da8c25a546a066a2dc,0xb1539e3ebdcf854dedf819f6232d1e447cfb129f7bf572e70295fb998bd8c85e,0x03aef606b4b82495d96af41cf1ed84b739a1de2bfb37bc1c0cfde2c53cf096aa,0x130ac25c06d0a78c43cee16ed4147a8a2337d8dc08571f397ca9ac15e1fc2ec2,0x7b9f4d9b9d0380987936892409571a5e0b6e9b538806ac662699a305304bd15d,0x6832812101826d0b63748615617865e97f09b944c344d3bbd7d50b5be617eb16,0x918265b00e10f59d74df8af13287d5465c19a072459da4ae7d94b20d4e66c1e8,0x0b57c528b17bebb5b75282268198cc2f48585d04488cdc16020206499ed61769]",
"account": "0xd6110A7756080a4e3BCF4e7EBBCA8E8aDFBC9962"
}
}
]
}
Loading
Loading