-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: foundry support for missing test and deployment script #45
Conversation
solc = '0.8.25' | ||
|
||
[fmt] | ||
ignore = ['./contracts/**/*'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@note here i'm opting to avoid linting the contracts all together. it can be something to consider tho once all issues/prs are close
it covers the test for the factory and reverts that were uncovered initially and we touched upon in the issues. Also it includes scripts for deployment to run a dry run for testing purposes and a multichain script which will deploy at once in all target chains. for running the tests: for running the scripts you can use the
similarly for the actual broadcasting and verification of contracts, before triggering those make sure that you have set properly all the vars in the |
|
||
// @note the array can be updated depending on your target chains to deploy | ||
// @note by default the script will deploy in all chains available in the toml file | ||
Chains[] memory targetDeploymentChains = new Chains[](6); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you can target the specifics chains which you will like to deploy at once, remove as you may see fit, but also remember to adapt the length of the array
forge script foundry_scripts/InjectorInfraMultiChainDeployment.s.sol \ | ||
--rpc-url polygon \ | ||
--slow \ | ||
-- multi \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@note here that this flag --multi
it is for multichain deployments
--multi
If present, --resume or --verify will be assumed to be a multi chain
deployment
@petrovska-petro LGTM. Let's go ahead and merge this + #46 , then lint (feel free to do so), and if we are finished wrap it up and I can go ahead and deploy. We've already deployed a test version to AVAX for the team to get a feel for it. Not the very most recent version, but after all functional changes. |
No description provided.