Test: it("should checkSufficientBalances and return false" unclear outcome on expect

[petrovska-petro]

Severity: potentially unexpected returned value in getBalanceDelta or miswording in test suite

Context: it seems that the test would like to signal that actually there is sufficient balances in the injector to cover the actual period. But it is checking for being negative or equal to zero, by the Natspec comments seems that negative value signals that there is an actual deficit. Is this behaviour desired?

Recommendation: to ensure that getBalanceDelta is returning the expected values we will advise to cover 3 scenarios in the suite:

1. deficit
2. exact balance
3. surplus

Also, it seems worth to give a reconsideration on wording in the Natspec comments or the test suite description, as while reviewing intention was not 100% clear.

Review stage

Balancer Maxis:

• Acknowledge
• Fixed

Onchainification Labs:

• Acknowledge correction/mitigation

[Tritium-VLK]

@Hyferion Can you please take a look/respond to this one?

[petrovska-petro]

@Hyferion could you please provide feedback on this issue to decide in which state is?

[petrovska-petro]

the three cases requested were covered in #45 and showed proper behaviour in the calculations. it is safe to closed.