Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites Dataview: Update margin alignment #94694

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Sites Dataview: Update margin alignment #94694

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92de061
Fix lint issues
DustyReagan Sep 18, 2024
111e654
Fix small width header issue
DustyReagan Sep 19, 2024
628c776
Remove right alignment of Actions column
DustyReagan Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 31 additions & 22 deletions client/hosting/sites/components/dotcom-style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,13 @@
.a4a-layout__top-wrapper,
.a4a-layout__body {
> * {
padding-inline: 8px;
padding-inline: 48px;
max-width: none;
max-width: 1400px !important;
margin-inline: auto !important;

@include breakpoint-deprecated(">660px") {
padding-inline: 8px;
}

@include breakpoint-deprecated(">960px") {
padding-inline: 26px;
}

@include break-huge {
padding-inline: 64px;
@media (max-width: 402px) {
padding-inline: 24px;
}
}
}
Expand Down Expand Up @@ -133,6 +128,21 @@
tbody tr.dataviews-view-table__row {
cursor: pointer;
}

.dataviews-view-table {
td:last-child {
.dataviews-view-table__cell-content-wrapper {
justify-content: flex-end;
DustyReagan marked this conversation as resolved.
Show resolved Hide resolved
}
}
th:last-child {
text-align: right;

.dataviews-view-table-header-button {
margin-right: 0;
}
}
}
}

table.dataviews-view-table {
Expand Down Expand Up @@ -555,20 +565,19 @@
}

.wpcom-site .main.a4a-layout.sites-dashboard.sites-dashboard__layout.preview-hidden {
@media (min-width: $break-xhuge) {
div.a4a-layout__viewport {
margin: 0 auto;
max-width: 1400px;
box-sizing: border-box;
}
.dataviews-wrapper {
margin: 0 auto;
max-width: 1400px;
box-sizing: border-box;
}
.dataviews-wrapper {
margin: 0 auto;
max-width: 1400px;
box-sizing: border-box;
}
div.a4a-layout__viewport {
margin: 0 auto;
max-width: 1400px;
box-sizing: border-box;
}

.a4a-layout-column__container {
margin: 0 -14px;
.dataviews-wrapper {
.dataviews-pagination {
@include break-large {
Expand Down
49 changes: 0 additions & 49 deletions client/hosting/sites/components/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@
.sites-dataviews__site {
.button {
flex-shrink: 0;
@include breakpoint-deprecated("<480px") {
width: 90px;
}
}
.sites-dataviews__site-name {
padding: 0;
Expand All @@ -66,27 +63,6 @@
&.sites-dashboard__layout:not(.preview-hidden) .sites-overview__page-subtitle {
display: none;
}

.dataviews-view-table tr th:first-child,
.dataviews-view-table tr td:first-child {
padding-left: 26px;
}
.dataviews-view-table tr th:last-child,
.dataviews-view-table tr td:last-child {
padding-right: 26px;
width: 20px;
white-space: nowrap;
}
}
@media (min-width: $break-huge) {
.dataviews-view-table tr th:first-child,
.dataviews-view-table tr td:first-child {
padding-left: 64px;
}
.dataviews-view-table tr th:last-child,
.dataviews-view-table tr td:last-child {
padding-right: 64px;
}
}

@media (max-width: 660px) {
Expand All @@ -104,10 +80,6 @@
.sites-overview {
overflow: hidden;

.a4a-layout__viewport {
padding-inline: 16px;
}

.sites-overview__page-title-container {
display: flex;
}
Expand Down Expand Up @@ -149,15 +121,6 @@
}
}

.dataviews-view-table tr th:first-child,
.dataviews-view-table tr td:first-child {
padding: 8px 16px 8px 16px;
}
.dataviews-view-table tr td:last-child {
padding: 0;
padding-inline-end: 16px;
}

.components-button.is-compact.has-icon:not(.has-text).dataviews-filters-button {
min-width: 40px;
}
Expand Down Expand Up @@ -188,14 +151,6 @@
display: none;
}

tr td:first-child {
padding-inline-start: 8px;
}

tr td:last-child {
padding-inline-end: 8px;
}

.item-preview__content {
padding: 10px 10px 88px; /* 88px matches the padding from PR #39201. */

Expand Down Expand Up @@ -233,10 +188,6 @@
.sites-overview {
padding: 0;

.a4a-layout__viewport {
padding-inline: 16px;
}

.a4a-layout__header-title {
font-size: rem(20px);
font-weight: 500;
Expand Down
1 change: 0 additions & 1 deletion client/sites-dashboard/components/sites-ellipsis-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ const SiteDropdownMenu = styled( DropdownMenu )( {
'> .components-button': {
height: '44px',
width: '44px',
marginRight: '-12px',
minWidth: 0,
color: 'var( --color-text-subtle )',
verticalAlign: 'middle',
Expand Down
Loading