-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sites Dataview: Update margin alignment #94694
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~8 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see all of those style hacks removed, and it's working well for me. I'm just not sure about aligning the "Actions" column to the right, and staying aligned with core.
Nice cleanup 👍 |
* Fix lint issues * Fix small width header issue * Remove right alignment of Actions column
Related to #94200
Proposed Changes
Of note is that this PR aligns the "Actions" column to the right to clarify the righthand design "lines."I removed this from this PR, so no special modifications are made to the "Actions" column.Before:
Screen.Recording.2024-09-19.at.11.02.07.AM.mp4
After:
Screen.Recording.2024-09-19.at.11.00.43.AM.mp4
Why are these changes being made?
Testing Instructions
Pre-merge Checklist