-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support links from several blocks #40275
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
The group placeholder shows a choice of group blocks, hovering over them shows [object Object]. This is because this code transforms them into ReactElements (which isn't officially supported) and they get rendered as strings. Discussion is ongoing in Gutenberg about the best way to display the support links. For now, to avoid the [object Object] problem, this pr removes the links from the blocks that trigger the problem.
f7e8b25
to
56c344e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this temporarily fixes the issue by falling back to default core messages.
Fixes Automattic/wp-calypso#96079
Proposed changes:
The group placeholder shows a choice of group blocks, hovering over them shows [object Object]. This is because this code transforms them into ReactElements (which isn't officially supported) and they get rendered as strings.
Discussion is ongoing in Gutenberg about the best way to display the support links. For now, to avoid the [object Object] problem, this pr removes the links from the blocks that trigger the problem.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Screen.Recording.2024-11-20.at.16.33.41.mov