Skip to content

Commit

Permalink
Remove support links from several blocks (#40275)
Browse files Browse the repository at this point in the history
The group placeholder shows a choice of group blocks, hovering over them
shows [object Object]. This is because this code transforms them into
ReactElements (which isn't officially supported) and they get rendered
as strings.

Discussion is ongoing in Gutenberg about the best way to display the
support links. For now, to avoid the [object Object] problem, this pr
removes the links from the blocks that trigger the problem.
  • Loading branch information
dsas authored Nov 21, 2024
1 parent 8fa8db6 commit 8031044
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Block Support Links: Removed support links for the group block and varients, to avoid an issue with the group placeholder displaying the block descriptions incorrectly.
Original file line number Diff line number Diff line change
Expand Up @@ -358,20 +358,6 @@ const blockInfoMapping: { [ key: string ]: { link: string; postId: number } } =
export const blockInfoWithVariations: {
[ key: string ]: { [ key: string ]: { link: string; postId: number } };
} = {
'core/group': {
group: {
link: 'https://wordpress.com/support/wordpress-editor/blocks/group-block/',
postId: 161882,
},
'group-row': {
link: 'https://wordpress.com/support/wordpress-editor/blocks/row-block/',
postId: 190036,
},
'group-stack': {
link: 'https://wordpress.com/support/wordpress-editor/blocks/row-block/',
postId: 190036,
},
},
'core/embed': {
soundcloud: {
link: 'https://wordpress.com/support/soundcloud-audio-player/',
Expand Down

0 comments on commit 8031044

Please sign in to comment.