Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wp-downgrade to incompatible plugins in wpcomsh #39264

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

zdenys
Copy link
Contributor

@zdenys zdenys commented Sep 6, 2024

Adding WP Downgrade (wp-downgrade) to incompatible plugins list in wpcomsh.

Fixes https://github.com/Automattic/wpcomsh/issues/1920

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

I discovered this plugin was active on a p1725456316432119-slack-CEYCDRUL9.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Follow the steps to test this branch (should be a comment posted by the bot below)
  • On your WoA dev site, install wp-downgrade by running wp plugin install wp-downgrade --activate
  • Navigate to the WoA dev site's /wp-admin/plugins.php page and confirm that the WP Downgrade is disabled.

Add wp-downgrade (aka WP Downgrade) to the list of incompatible plugins in wpcomsh since it's mentioned publicly https://wordpress.com/support/plugins/incompatible-plugins/#database-file-system-altering-plugins
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@zdenys zdenys closed this Sep 7, 2024
@zdenys zdenys deleted the add-wp-downgrade-to-incompatible-plugins-in-wpcomsh branch September 7, 2024 14:07
@zdenys zdenys restored the add-wp-downgrade-to-incompatible-plugins-in-wpcomsh branch September 7, 2024 14:09
@zdenys zdenys reopened this Sep 7, 2024
@zdenys zdenys marked this pull request as ready for review September 21, 2024 13:37
@villanovachile
Copy link
Contributor

Tested and works as expected:

image

@villanovachile
Copy link
Contributor

Next you'll want to make the necessary changes to wp-calypso as well to this file: https://github.com/Automattic/wp-calypso/blob/ff7cc132fb5d0ca61f45cffa1e22fd445035709d/client/my-sites/plugins/plugin-compatibility.js#L11

@zdenys zdenys merged commit e537592 into trunk Sep 24, 2024
54 checks passed
@zdenys zdenys deleted the add-wp-downgrade-to-incompatible-plugins-in-wpcomsh branch September 24, 2024 12:46
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
* Add wp-downgrade to incompatible plugins in wpcomsh

Add wp-downgrade (aka WP Downgrade) to the list of incompatible plugins in wpcomsh since it's mentioned publicly https://wordpress.com/support/plugins/incompatible-plugins/#database-file-system-altering-plugins

* Updated the spacing/tabs

* Added wp-downgrade plugin to the incompatible plugins list in wpcomsh

---------

Co-authored-by: zdenys <@zdenys>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants