Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add incompatible plugin wp-downgrade to the list to match wpcomsh #94849

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

zdenys
Copy link
Contributor

@zdenys zdenys commented Sep 24, 2024

Related to:

Proposed Changes

  • This PR adds wp-downgrade incompatible plugin found in wpcomsh that is missing in Calypso.

Why are these changes being made?

  • While wpcomsh disables plugins that are already installed, this array in Calypso is used to prevent the installation of incompatible plugins on the marketplace.

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add-wp-downgrade-to-incompatible-plugins on your sandbox.

@zdenys zdenys marked this pull request as ready for review September 24, 2024 13:03
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~7 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                                +15 B  (+0.0%)       +5 B  (+0.0%)
marketplace                            +15 B  (+0.0%)       +2 B  (+0.0%)
jetpack-cloud-plugin-management        +15 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@zdenys
Copy link
Contributor Author

zdenys commented Sep 24, 2024

Before After
Screenshot on 2024-09-24 at 15:06:15 Screenshot on 2024-09-24 at 15:05:35

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 24, 2024
@zdenys
Copy link
Contributor Author

zdenys commented Sep 24, 2024

@sejas 👋 It's my first PR in Calypso and I am following the footsteps (from #93650) by @villanovachile 💟 so I hope you don't mind that I tag you as a reviewer. Let me know if you mind though. Thank you!

@zdenys zdenys requested a review from sejas September 24, 2024 13:10
@zdenys
Copy link
Contributor Author

zdenys commented Sep 24, 2024

FYI: The plugin WP Downgrade is already in the public list of incompatible plugins https://wordpress.com/support/plugins/incompatible-plugins/#database-file-system-altering-plugins

@villanovachile
Copy link
Collaborator

Working for me!

image

Copy link
Member

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zdenys !, Congrats in your first PR to Calypso! 👏

I tested it in calypso live by accessing https://wordpress.com/plugins/wp-downgrade
I confirm I see the notice and I cannot install wp-downgrade plugin in any of my sites.

Let me know if you need help deploying it.

Screenshot 2024-10-08 at 15 12 04

@zdenys zdenys merged commit 9be3e31 into trunk Oct 8, 2024
15 checks passed
@zdenys zdenys deleted the add-wp-downgrade-to-incompatible-plugins branch October 8, 2024 14:29
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants