Top Posts & Pages Block: Remove Deleted Content

[Aurorum]

Fixes Automattic/wp-calypso#90308

Proposed changes:

• Filters out deleted content from the Top Posts and Pages block.

Jetpack product discussion

N/A.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Create a post and view it several times from an incognito browser (note: stats are cached for five minutes)
• Add a Top Posts and Pages block
• Delete the post, and confirm that the post currently still appears in the block
• Confirm that this change ensures the post no longer appears

For context, this issue only applies to posts which are published and viewed several times, then subsequently deleted; the API endpoint still considers them a 'most viewed post', even though it has been deleted. It doesn't apply to the randomly generated posts whenever there aren't enough posts provided by the endpoint.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for September 3, 2024 (scheduled code freeze on September 2, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jeherve]

This feels like something that may be best addressed higher up, at least in the get_top_posts method of WPCOM_Stats.

@Automattic/red What's your take on this?

[Aurorum]

I originally thought so too, but I concluded that there might be cases where it’s beneficial to display all the top posts irrespective of whether they’ve been deleted - for example, in the Stats dashboard on the backend, where users might want to compare all posts regardless of whether they’ve now been deleted.

I think this is the only case where the top posts list is actually shown to site readers, which is where I felt deleted posts ought to be removed.

Happy to change it if you reckon that’d be more fitting though!

[github-actions]

This PR has been marked as stale. This happened because:

• It has been inactive for the past 3 months.
• It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, etc.

If this PR is still useful, please do a [trunk merge or rebase](https://github.com/Automattic/jetpack/blob/trunk/docs/git-workflow.md#keeping-your-branch-up-to-date) and otherwise make sure it's up to date and has clear testing instructions. You may also want to ping possible reviewers in case they've forgotten about it. Please close this PR if you think it's not valid anymore — if you do, please add a brief explanation.

If the PR is not updated (or at least commented on) in another month, it will be automatically closed.

[kangzj]

Works well for me. Thanks for the contribution!