Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Gardening: Attempt to Fix OSS Workflow #37252

Merged
merged 2 commits into from
May 7, 2024

Conversation

Aurorum
Copy link
Contributor

@Aurorum Aurorum commented May 6, 2024

Proposed changes:

Tests from non-a12ns currently immediately fail - eg. #37251

main: Starting task flagOss
Error: main: Task flagOss failed with error: HttpError: User does not exist or is not a public member of the organization - https://docs.github.com/rest/orgs/members#check-public-organization-membership-for-a-user

I think it should be okay if the check is wrapped in a try statement rather than assuming it won't error? Seems like the error is intentional.

Jetpack product discussion

N/A.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Not sure this is possible for an OSS citizen to actually test, so would appreciate some eyes on whether this seems logical.

cc @jeherve - sorry, assuming that you won't be notified unless I ping you until this is fixed.

@github-actions github-actions bot added [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management labels May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well, thank you for the contribution!

@jeherve jeherve merged commit 1181465 into Automattic:trunk May 7, 2024
52 of 53 checks passed
pkuliga pushed a commit that referenced this pull request May 9, 2024
* Repo Gardening: Attempt to Fix OSS Workflow

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants