Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass Privater: Display total fetched count without filtering #1610

Merged

Conversation

marcustyphoon
Copy link
Collaborator

Description

Resolves #1609.

This changes the "checked x" count that Mass Privater shows while fetching posts to include all posts without any filtering, ensuring that it continues to increment in real time even if the posts currently being fetched aren't relevant.

This includes counting the same post multiple times if it has multiple searched tags and gets fetched multiple times; do you think this makes sense? (Maybe it makes "checked x" slightly inaccurate; that could be "fetched x" or "downloaded x" something, I dunno.) There's a tradeoff here.

Testing steps

I did not really test this, as I don't have enough private posts to notice the difference.

@AprilSylph
Copy link
Owner

This includes counting the same post multiple times if it has multiple searched tags and gets fetched multiple times; do you think this makes sense? (Maybe it makes "checked x" slightly inaccurate; that could be "fetched x" or "downloaded x" something, I dunno.)

After much thought, I'm concluding that I don't care. It's probably a rare enough scenario that it's not worth the mental effort to accommodate writing 100% accurate copy for.

Copy link
Owner

@AprilSylph AprilSylph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Easily tested on a blog with only 22 posts, 20 of which were private.

@marcustyphoon marcustyphoon merged commit 5ec959a into AprilSylph:master Nov 23, 2024
2 checks passed
@marcustyphoon marcustyphoon deleted the mass-privater-accurate-count branch November 23, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass Privater: "(checked {x})" count can be incorrect
2 participants