Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass Privater: Add mass unprivate functionality #1639

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Collaborator

@marcustyphoon marcustyphoon commented Oct 28, 2024

Description

Per a number of user requests, this adds the ability to unprivate posts to Mass Privater, including by tag. There's currently no realistic way to do this without an extension, since you can't find all of your private posts (that contain a certain tag or otherwise) through the Tumblr UI. No, it's not fast, but it's faster than manually scrolling through your archive, that's for sure.

Resolves #1626.

Currently contains the diff of #1610; must be rebased after it is merged (or close it if merged first).

Testing steps

Comment on lines +267 to +272
apiFetch(`/v2/blog/${uuid}/posts/${postData.id}`, {
method: 'PUT',
body: {
...createEditRequestBody(postData),
state: 'published'
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm. the fact that this will only work on NPF/text/answer posts is... concerning.

i feel like we should have a separate "incompatible" count to show to the user, rather than trying to action on them here, knowing that the operation will always fail.

do we have a util for NPF compatibility yet? i feel like we need one.
if a post is stored in blocks format, or the original type is text, or the original type is note, it should be editable via NPF endpoints.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, shoot.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And yes we do; it currently returns isBlocksPostFormat || shouldOpenInLegacy === false;).

@marcustyphoon marcustyphoon self-assigned this Nov 12, 2024
@marcustyphoon marcustyphoon marked this pull request as draft November 12, 2024 22:41
@marcustyphoon marcustyphoon added the help wanted Extra attention is needed label Jan 4, 2025
@marcustyphoon marcustyphoon removed their assignment Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass Unprivater as an option to Mass Privater
2 participants