Fix program selection for profile page #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillebrulotte
previously approved these changes
Sep 18, 2023
|
Enfait, pourrais-tu regarder vite vite si tu vois pourquoi c'est pas centré ici svppp ? :D 
|
Je pense que l'appli était en breakpoint mid animation quand j'ai pris la capture d’écran. La page est bien centrée sur mon debug en ce moment. |
mataai
added a commit
that referenced
this pull request
Sep 21, 2023
* Fix program selection for profile page (#846) * Ajout code programe baccalaureat informatique distribuée * define program by the number of registered credits * Sort list entries to have main program first. * fix pipeline please * [BOT] Applying version. --------- Co-authored-by: mataai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #845
📖 Description
I added the new program code in the program credits enum. (Source of the data is my account, I'm in the program)
I added a check to the profile page to set the current program based on the number of credits currently in progress in that program.
🧪 How Has This Been Tested?
As far as my understand of the app goes, the modified part of the view model is self contained and doesn't interact with other parts of the app. The existing unit tests for the widget have been check and all have passed.
☑️ Checklist before requesting a review
version: Major,version: Minororversion: Patch.🖼️ Screenshots (if useful):
Personal information removed for privacy reasons.
Before:
After: