Skip to content

Commit

Permalink
Fix program selection for profile page (#846) (#852)
Browse files Browse the repository at this point in the history
* Fix program selection for profile page (#846)

* Ajout code programe baccalaureat informatique distribuée

* define program by the number of registered credits

* Sort list entries to have main program first.

* fix pipeline please

* [BOT] Applying version.

---------

Co-authored-by: mataai <[email protected]>
  • Loading branch information
mataai and mataai authored Sep 21, 2023
1 parent 94860df commit 9133035
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 10 deletions.
4 changes: 1 addition & 3 deletions lib/core/constants/programs_credits.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@ class ProgramCredits {
"6556": 117,
"6557": 118,
"7086": 116,
// TODO: Ajouter le code lorsque le programme sera en vigeur
// (https://www.etsmtl.ca/etudes/premier-cycle/Baccalaureat-informatique-distribuee)
// "À venir" : 90",
"6646": 90,
"5766": 30,
"4567": 30,
"4412": 30,
Expand Down
18 changes: 13 additions & 5 deletions lib/core/viewmodels/profile_viewmodel.dart
Original file line number Diff line number Diff line change
Expand Up @@ -51,21 +51,27 @@ class ProfileViewModel extends FutureViewModel<List<Program>> {
int percentage = 0;

if (programList.isNotEmpty) {
Program currentProgram = programList.first;
for (final program in programList) {
if (int.parse(program.registeredCredits) >
int.parse(currentProgram.registeredCredits)) {
currentProgram = program;
}
}
final int numberOfCreditsCompleted =
int.parse(programList[programList.length - 1].accumulatedCredits);
final String code = programList[programList.length - 1].code;
int.parse(currentProgram.accumulatedCredits);
final String code = currentProgram.code;
bool foundMatch = false;

programCredits.programsCredits.forEach((key, value) {
if (key == code ||
programList[programList.length - 1].name.startsWith(key)) {
if (key == code || currentProgram.name.startsWith(key)) {
percentage = (numberOfCreditsCompleted / value * 100).round();
foundMatch = true;
}
});

if (!foundMatch) {
final String programName = programList[programList.length - 1].name;
final String programName = currentProgram.name;
analyticsService.logEvent("profile_view",
'The program $programName (code: $code) does not match any program');
percentage = 0;
Expand All @@ -91,6 +97,8 @@ class ProfileViewModel extends FutureViewModel<List<Program>> {
}

_programList.sort((a, b) => b.status.compareTo(a.status));
_programList
.sort((a, b) => a.registeredCredits.compareTo(b.registeredCredits));

return _programList;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/l10n/intl_en.arb
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{}
{­}
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: The 4th generation of ÉTSMobile, the main gateway between the Éco
# pub.dev using `pub publish`. This is preferred for private packages.
publish_to: 'none' # Remove this line if you wish to publish to pub.dev

version: 4.25.2+1
version: 4.25.3+1

environment:
sdk: ">=2.10.0 <3.0.0"
Expand Down

0 comments on commit 9133035

Please sign in to comment.