-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(packages): add ESLint, vscode extensions, and github workflows #145
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ab7708d
chore(packages): added eslint and scripts
nlewis84 336ec4e
chore(linter): brought over several files from Admin
nlewis84 47738a2
chore(linter): brought over several files from Admin
nlewis84 f0f2afe
chore(linter): more config
nlewis84 9da4265
chore(linter): prettier run
nlewis84 41a9b28
chore(vscode): add vscode folder and linter run
nlewis84 eb5b35f
chore(vscode): add the vscode folder
nlewis84 90dc802
chore(linter): more setup
nlewis84 49d16b0
fix: put back a file I deleted by accident
nlewis84 fe38c4f
lint
nlewis84 dd3fde9
chore(gh workflow): add lint workflow
nlewis84 ad109db
chore(gh): changes to lint ci
nlewis84 3cedd2f
chore(gh): bump node version
nlewis84 2f89084
Update web-embeds/jsconfig.json
vinnyjth f9ea616
Update web-embeds/jsconfig.json
vinnyjth 58e5646
lint
nlewis84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
name: Lint Web Embeds | ||
|
||
on: | ||
push: | ||
paths: | ||
- 'web-embeds/**' | ||
pull_request: | ||
paths: | ||
- 'web-embeds/**' | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- name: Set up Node.js | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: '16' | ||
|
||
- name: Install Dependencies | ||
run: cd web-embeds && yarn install | ||
|
||
- name: Run Lint | ||
run: cd web-embeds && yarn lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"recommendations": [ | ||
"dbaeumer.vscode-eslint", | ||
"github.vscode-pull-request-github", | ||
"eamodio.gitlens", | ||
"esbenp.prettier-vscode", | ||
"meganrogge.template-string-converter" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
// Use IntelliSense to learn about possible attributes. | ||
// Hover to view descriptions of existing attributes. | ||
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
"version": "0.2.0", | ||
"configurations": [ | ||
{ | ||
"type": "chrome", | ||
"request": "launch", | ||
"name": "Launch Chrome against localhost", | ||
"url": "http://localhost:3000", | ||
"webRoot": "${workspaceFolder}/app" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"prettier.trailingComma": "es5", | ||
"editor.formatOnSave": true, | ||
"editor.defaultFormatter": "esbenp.prettier-vscode", | ||
"editor.tabSize": 2, | ||
"eslint.validate": [ | ||
"javascript", | ||
"javascriptreact", | ||
"typescript", | ||
"typescriptreact" | ||
], | ||
"[javascriptreact]": { | ||
"editor.defaultFormatter": "esbenp.prettier-vscode" | ||
}, | ||
"editor.codeActionsOnSave": { | ||
"source.fixAll.eslint": "explicit", | ||
"source.fixAll.prettier": "explicit" | ||
}, | ||
"prettier.requireConfig": true | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,6 @@ | |
"packages": [ | ||
"packages/*" | ||
], | ||
"nohoist": [] | ||
"nohoist": [ ] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
node_modules/ | ||
build/ | ||
|
||
widget/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
module.exports = { | ||
extends: ["react-app", "plugin:prettier/recommended"], | ||
plugins: ["simple-import-sort", "import"], | ||
rules: { | ||
"import/first": "error", | ||
"import/newline-after-import": "error", | ||
"import/no-duplicates": "error", | ||
"import/order": [ | ||
"error", | ||
{ | ||
groups: [ | ||
["external", "builtin"], | ||
"internal", | ||
["sibling", "parent"], | ||
"index", | ||
], | ||
pathGroups: [ | ||
{ | ||
pattern: "@(react|react-native)", | ||
group: "external", | ||
position: "before", | ||
}, | ||
{ | ||
pattern: "@src/**", | ||
group: "internal", | ||
}, | ||
], | ||
pathGroupsExcludedImportTypes: ["internal", "react"], | ||
"newlines-between": "always", | ||
alphabetize: { | ||
order: "asc", | ||
caseInsensitive: true, | ||
}, | ||
}, | ||
], | ||
"lines-around-comment": [ | ||
"error", | ||
{ | ||
allowArrayStart: true, | ||
allowBlockStart: true, | ||
allowClassStart: true, | ||
allowObjectStart: true, | ||
beforeBlockComment: true, | ||
beforeLineComment: true, | ||
}, | ||
], | ||
"spaced-comment": ["error", "always"], | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
node_modules | ||
|
||
/build | ||
.env | ||
|
||
widget |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"semi": true, | ||
"singleQuote": false, | ||
"trailingComma": "es5" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"compilerOptions": { | ||
"baseUrl": "." | ||
} | ||
"baseUrl": ".", | ||
vinnyjth marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}, | ||
vinnyjth marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,21 @@ | ||
<!DOCTYPE html> | ||
<!doctype html> | ||
<html lang="en"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. my heart breaths easy now |
||
|
||
<head> | ||
<meta charset="utf-8" /> | ||
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
<meta name="theme-color" content="#000000" /> | ||
<meta name="description" content="Web embed created using The Apollos Project" /> | ||
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" /> | ||
<!-- | ||
<head> | ||
<meta charset="utf-8" /> | ||
<link rel="icon" href="%PUBLIC_URL%/favicon.ico" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
<meta name="theme-color" content="#000000" /> | ||
<meta | ||
name="description" | ||
content="Web embed created using The Apollos Project" | ||
/> | ||
<link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" /> | ||
<!-- | ||
manifest.json provides metadata used when your web app is installed on a | ||
user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/ | ||
--> | ||
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" /> | ||
<!-- | ||
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" /> | ||
<!-- | ||
Notice the use of %PUBLIC_URL% in the tags above. | ||
It will be replaced with the URL of the `public` folder during the build. | ||
Only files inside the `public` folder can be referenced from the HTML. | ||
|
@@ -22,20 +24,30 @@ | |
work correctly both with client-side routing and a non-root public URL. | ||
Learn how to configure a non-root public URL by running `npm run build`. | ||
--> | ||
<title>Apollos Web Embeds</title> | ||
<style> | ||
body { | ||
font-family: 'Inter', -apple-system, BlinkMacSystemFont, Segoe UI, | ||
Roboto, Oxygen, Ubuntu, Cantarell, Fira Sans, Droid Sans, | ||
Helvetica Neue, sans-serif; | ||
} | ||
</style> | ||
</head> | ||
<title>Apollos Web Embeds</title> | ||
<style> | ||
body { | ||
font-family: | ||
"Inter", | ||
-apple-system, | ||
BlinkMacSystemFont, | ||
Segoe UI, | ||
Roboto, | ||
Oxygen, | ||
Ubuntu, | ||
Cantarell, | ||
Fira Sans, | ||
Droid Sans, | ||
Helvetica Neue, | ||
sans-serif; | ||
} | ||
</style> | ||
</head> | ||
|
||
<body> | ||
<noscript>You need to enable JavaScript to run this app.</noscript> | ||
<!-- This is an example of how to use the apollos widgets --> | ||
<!-- <div | ||
<body> | ||
<noscript>You need to enable JavaScript to run this app.</noscript> | ||
<!-- This is an example of how to use the apollos widgets --> | ||
<!-- <div | ||
data-church="cedar_creek" | ||
data-type="FeatureFeed" | ||
data-feature-feed="FeatureFeed:5aae43e6-3526-4cd2-8dfe-771d2ce8a333" | ||
|
@@ -45,15 +57,15 @@ | |
style="max-width: 1180px; padding: 40px; margin: auto; margin-top: 20px" | ||
></div> --> | ||
|
||
<!-- <div | ||
<!-- <div | ||
data-type="FeatureFeed" | ||
data-church="liquid_church" | ||
data-feature-feed="FeatureFeed:d292fd8c-5b9f-4cd7-a2fe-9d7d0914c34f" | ||
data-placeholder="Life Is Hard. How Can We Help?" | ||
data-modal="true" | ||
class="apollos-widget" | ||
></div> --> | ||
<!-- | ||
<!-- | ||
<div | ||
data-church="cedar_creek" | ||
data-type="Search" | ||
|
@@ -62,9 +74,14 @@ | |
class="apollos-widget" | ||
style="max-width: 1180px; padding: 40px; margin: auto; margin-top: 20px" | ||
></div> --> | ||
<div data-church="bayside" data-type="Auth" data-modal="true" class="apollos-widget" | ||
style="max-width: 1180px; padding: 40px; margin: auto; margin-top: 20px"></div> | ||
<!-- | ||
<div | ||
data-church="bayside" | ||
data-type="Auth" | ||
data-modal="true" | ||
class="apollos-widget" | ||
style="max-width: 1180px; padding: 40px; margin: auto; margin-top: 20px" | ||
></div> | ||
<!-- | ||
This HTML file is a template. | ||
If you open it directly in the browser, you will see an empty page. | ||
|
||
|
@@ -74,6 +91,5 @@ | |
To begin the development, run `npm start` or `yarn start`. | ||
To create a production bundle, use `npm run build` or `yarn build`. | ||
--> | ||
</body> | ||
|
||
</html> | ||
</body> | ||
</html> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you!