chore(packages): add ESLint, vscode extensions, and github workflows #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
extra points for making sure lint runs during the |
nlewis84
changed the title
|
Can't tell if the vercel deployment is failing because this is a draft. It's ready for review aside from the deploy issue. |
vinnyjth
reviewed
Jan 24, 2024
vinnyjth
reviewed
Jan 24, 2024
vinnyjth
requested changes
Jan 24, 2024
| @@ -0,0 +1,27 @@ | |||
| name: Lint Web Embeds | |||
| @@ -1,19 +1,21 @@ | |||
| <!DOCTYPE html> | |||
| <!doctype html> | |||
|
@vinnyjth The vercel deploy is passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Issue
Switching between repos was causing havoc due to differences in lint/prettier setups
✏️ Solution
web-embedsin line with lint/prettier setup on Apollos Adminvscodeextensions config as well to make context switching easier🔬 To Test
yarnin theweb-embedsfolderyarn formatand see no changesyarn lintand see no changes📸 Screenshots