Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): allow non-modular includes in framework modules #584

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix(build): allow non-modular includes in framework modules #584

merged 2 commits into from
Dec 3, 2024

Conversation

marfavi
Copy link
Member

@marfavi marfavi commented Dec 3, 2024

Allows build for iOS on Macbooks

@marfavi marfavi enabled auto-merge (squash) December 3, 2024 18:16
@Slug-Boi Slug-Boi self-requested a review December 3, 2024 19:16
Slug-Boi
Slug-Boi approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Slug-Boi Slug-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good fixes the build error 👍🏻

@marfavi marfavi merged commit 3dc264a into main Dec 3, 2024
8 checks passed
@marfavi marfavi deleted the non-modular-includes branch December 3, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slug-Boi Slug-Boi Slug-Boi approved these changes

Assignees

@Slug-Boi Slug-Boi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marfavi @Slug-Boi