-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: React lint warnings #660
Conversation
Thanks for configuring the linter. I think that indeed we should review the missing dependencies for the hooks manually. #648 should fix some of those warnings already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge some of these adjustments by the linter already, and take care of the missing / incorrect dependencies in the react hooks later. Perhaps as a team we should review our linter settings, since I'm not sure everyone has one configured.
But please undo the change removing finalizeSession
from API.js
and Final.js
. Indeed, I see that finalize()
is never called, while it should probably be placed into the useEffect
hook as a cleanup function.
- Combine conditions for skippable and valid form elements into a single line. - Add explicit return for elements that don't meet criteria. - Enhance code readability and maintainability.
5eb9553
to
d29bcee
Compare
I've looked it up and you have updated the call to I think then it got removed after merging 1cc4ac4#diff-dd2727c4ba071122a678bb23e7b9b2833fd33ab5995321f1df7d3dc4f4523d33 Apart from that, I don't know if it ever behaved like it should have? I can imagine when you click a link that also has a |
I will merge this and I've addressed the finalize session not being called as a seperate issue in #676 ! |
This PR intends to resolve the React warnings as described in #598
@BeritJanssen the remaining linting errors are all
react-hooks/exhaustive-deps
, e.g. "missing" or "incorrect" dependencies. Now,eslint
proposes fixes here, but I'm not completely aware of what happens and should happen exactly so I'm afraid to break stuff, and I don't want to risk that over some linting warnings. Perhaps you can look into these or we can look at them together in the future?