Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize session does not get called #676

Closed
drikusroor opened this issue Dec 19, 2023 · 0 comments · Fixed by #689
Closed

Finalize session does not get called #676

drikusroor opened this issue Dec 19, 2023 · 0 comments · Fixed by #689

Comments

@drikusroor
Copy link
Contributor

drikusroor commented Dec 19, 2023

Describe the bug
The so called finalizeSession endpoint does not get called at the end of a session in the frontend (anymore). Calling this endpoint tells the backend that the session is over. It used to be called, but somewhere during development the call got removed. See also this PR comment

To Reproduce
Steps to reproduce the behavior:

  1. Start any experiment
  2. Keep the developers tools open in your browser on the network tab
  3. Finish it
  4. Check the network tab and confirm that /session/{id}/finalize does not get called

Expected behavior
The finalize session endpoint does get called when the session is over

Screenshots
n/a

Desktop (please complete the following information):
n/a

Smartphone (please complete the following information):
n/a

Additional context
Related to #598 and #660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant