Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Altinn / altinn-notifications Public

Notifications You must be signed in to change notification settings
Fork 3
Star 2

Code
Issues 39
Pull requests
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

#328 Implementation of API logic for placing a SMS notifications order#384

Merged

khanrn merged 44 commits intomainAltinn/altinn-notifications:mainfrom sms/328Altinn/altinn-notifications:sms/328Copy head branch name to clipboard

Jan 30, 2024

+973-6

Conversation Commits44 (44)Checks Files changed

Commits

Commits on Jan 28, 2024

RecipientExt Phone number property added
khanrn
committed
SMS notification order request data model added
khanrn
committed
SMS notification orders controller added
khanrn
committed
SMS phone number validation initiated
khanrn
committed
Phone number validation added to singleton
khanrn
committed
Changed PhoneNumber to MobileNumber
khanrn
committed
With rebase phone changed to mobile
khanrn
committed
Change of phone to mobile
khanrn
committed
Attribute for SMS address point added
khanrn
committed
Mobile number validation rules regex fix
khanrn
committed
Validator test initiated for SMS notifiaction order request
khanrn
committed
Validatee recipient provided for SMS return true added
khanrn
committed
Validatee recipient provided for SMS return false added
khanrn
committed
Validate SMS recipient not defined return false added
khanrn
committed
Validate send time has local timezone return true added
khanrn
committed
Validate send time has UTC Now timezone return true added
khanrn
committed
Validate send time has unspecified timezone return false added
khanrn
committed
Validate Send Numbwer missing returns false
khanrn
committed
Type added to the validationResult variable
khanrn
committed
Test for valid SMS number added
khanrn
committed
Explicit type added to the variable
khanrn
committed
Explicit type added to the variable
khanrn
committed
Type definition for recipients variable fixed
khanrn
committed
Sender Number removed from must rule
khanrn
committed
Order mapper helper function added for getting mobile number
khanrn
committed
Norwegian phone number strict validation added
khanrn
committed
Tests adapted for Norwegian phone numbet validation
khanrn
committed
Test refactored for readability purpose
khanrn
committed
Typo fixed
khanrn
committed
Both MapToRecipientExt tests merged into one
khanrn
committed
SMS order mapper moved to OrderMapper class
khanrn
committed
SMS order mapper tests added
khanrn
committed
Fixed merge conflicts with main
khanrn
committed
Integration tests added for the SMS notificaitons API
khanrn
committed
Sender number changed to Altinn for integration tests
khanrn
committed
PostTests API base path fixed for integration tests
khanrn
committed

Commits on Jan 29, 2024

Revert:Removed the k6 tests added with integration tests
khanrn
committed
Ternary to if-else to remove code smell
khanrn
committed
Removed 5 digit pass as LinkMobility need 9 digits
khanrn
committed
Validation logic changed for SMS mobile numbers
khanrn
committed

Commits on Jan 30, 2024

RegEx removed from validation logic
khanrn
committed
Invalid mobile number error message updated

khanrn
and
acn-sbuad
authored
Arguments fixed for the tests
khanrn
committed
Tests messgae update
khanrn
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.