Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#328 Implementation of API logic for placing a SMS notifications order #384

Merged
merged 44 commits into from
Jan 30, 2024
Merged

#328 Implementation of API logic for placing a SMS notifications order #384

merged 44 commits into from
Jan 30, 2024

Conversation

khanrn
Copy link
Contributor

@khanrn khanrn commented Jan 22, 2024 •
edited
Loading

Implementation of API logic for placing a SMS notifications order

Description

  • Added PhoneNumber property to RecipientExt class
  • Added SmsNotificationOrderRequestExt to represent an SMS notification order request externally for customers
  • SMS added as an address type to AddressType enum.
  • An address point for SMS added
  • SMS notification orders controller added
  • Attribute added for SMS address point
  • Tests for SMS request validator added

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@khanrn khanrn force-pushed the sms/328 branch 2 times, most recently from b4b4c09 to 420e344 Compare January 22, 2024 18:10
@khanrn khanrn marked this pull request as ready for review January 24, 2024 15:40
@khanrn khanrn requested a review from acn-sbuad January 26, 2024 13:26
@khanrn khanrn requested a review from acn-sbuad January 26, 2024 14:38
@acn-sbuad
Copy link
Contributor

A couple of code smells flagged by SonarCloud. Should be an easy fix, @codemascot.

@khanrn khanrn requested a review from acn-sbuad January 29, 2024 09:41
@khanrn khanrn requested a review from acn-sbuad January 29, 2024 11:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
97.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khanrn khanrn requested a review from acn-sbuad January 30, 2024 09:08
acn-sbuad
acn-sbuad approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@acn-sbuad acn-sbuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈

@khanrn khanrn merged commit fb1f0ff into main Jan 30, 2024
7 checks passed
@khanrn khanrn deleted the sms/328 branch January 30, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acn-sbuad acn-sbuad acn-sbuad approved these changes

@SandGrainOne SandGrainOne Awaiting requested review from SandGrainOne

@tba76 tba76 Awaiting requested review from tba76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khanrn @acn-sbuad @SandGrainOne @tba76